Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41616

Non-trusted pull requests should use a probe against the trusted revision not the PR's revision

XMLWordPrintable

      See JENKINS-41561,

      If a PR is not trusted and has a Jenkinsfile but the target branch of the PR does not have a Jenkinsfile, we should not report that as a PR matching the Jenkinsfile criteria as the Jenkinsfile should be sourced from the trusted revision (where there is none)

      The current behaviour is that the PR will be flagged as matching the criteria and hence a build attempt will be started, but as the trusted revision does not have the Jenkinsfile the build will fail.

      We should never even try to build in the first case for such an untrusted PR

          [JENKINS-41616] Non-trusted pull requests should use a probe against the trusted revision not the PR's revision

          Jesse Glick added a comment -

          I think it is fine for the build to fail. Indeed arguably SCMBinder should always fail when the trusted Jenkinsfile differs from the untrusted one, rather than print a message and continue with a different script. ReadTrustedStep already has that stricter behavior.

          Jesse Glick added a comment - I think it is fine for the build to fail. Indeed arguably SCMBinder should always fail when the trusted Jenkinsfile differs from the untrusted one, rather than print a message and continue with a different script. ReadTrustedStep already has that stricter behavior.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/8272f20a872ce4fbafb6417b00bdd5aea0a43e7b
          Log:
          [FIXED JENKINS-41616] Non-trusted pull requests should use a probe against the trusted revision not the PR's revision

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8272f20a872ce4fbafb6417b00bdd5aea0a43e7b Log: [FIXED JENKINS-41616] Non-trusted pull requests should use a probe against the trusted revision not the PR's revision

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: