• Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2

      There's more cleanup I'd like to see, but this ticket is specifically for colour scheme info.

      Suggestions:

      • Remove all the less functions that are generating colours with things like "lighten" etc, replace with plain hex colours
      • Remove all the instances where we have alpha values on colours that aren't actually meant to be over different backgrounds, replace with plain hex colours
      • Audit the list of colours declared in `theme.less` and `variables.less`
        • Remove everything we're not using
        • Extract into a "colour scheme only" include - with comments about where they should be used
        • Enforce a (short) list of specific greys
        • Make random threats of bodily harm on anybody wrecking up (or ignoring) said new colour bible

          [JENKINS-42385] Clean up JDL css colours

          Cliff Meyers added a comment -

          I think we should implement JENKINS-36858 ahead of this issue so that "dashboard" and other modules can easily get access to brand colors, etc where needed.

          Cliff Meyers added a comment - I think we should implement JENKINS-36858 ahead of this issue so that "dashboard" and other modules can easily get access to brand colors, etc where needed.

          Josh McDonald added a comment -

          I'll duplicate what I wrote there - I would like to change the JDL so we're publishing pre-transform, just a compilation of .JSX and .less files, with the tests and stories stripped out. We'd get a lot of benefits, not just the ability to easily reference the css theme and mixins, but Idea would be able to make sense of the module for completion / error highlighting, instead of the jumbled mess you get from Babel which for some reason Idea won't parse.

          Josh McDonald added a comment - I'll duplicate what I wrote there - I would like to change the JDL so we're publishing pre-transform, just a compilation of .JSX and .less files, with the tests and stories stripped out. We'd get a lot of benefits, not just the ability to easily reference the css theme and mixins, but Idea would be able to make sense of the module for completion / error highlighting, instead of the jumbled mess you get from Babel which for some reason Idea won't parse.

          Cliff Meyers added a comment -

          Sounds good. I think our goal for this task should be a nice clean "colors.less" or similar, which we could easily do first as a smaller task. We could copy that into dashboard or personalization in the mean time, to eliminate the color duplication. Then if we do a full-blown rework of how the JDL is published, that stuff can just go away eventually.

          Cliff Meyers added a comment - Sounds good. I think our goal for this task should be a nice clean "colors.less" or similar, which we could easily do first as a smaller task. We could copy that into dashboard or personalization in the mean time, to eliminate the color duplication. Then if we do a full-blown rework of how the JDL is published, that stuff can just go away eventually.

            Unassigned Unassigned
            sophistifunk Josh McDonald
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: