Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42745

WindowsSlaveInstaller#generateXml() produces invalid XML in 1.7

      Currently the API produces a configuration with unresolved macros.

      There was an intention to deprecate the API, but use-case like JENKINS-42743 are actually valid. The old API should produce the formally correct XML at least

          [JENKINS-42745] WindowsSlaveInstaller#generateXml() produces invalid XML in 1.7

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
          src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java
          http://jenkins-ci.org/commit/windows-slave-installer-module/89cffceb16b9969bc79c4f7308cab0c19dce7f07
          Log:
          JENKINS-42745 - Windows Agent Installer should generate valid jenkins-slave.xml for old APIs

          This change is maybe quite over-engineered, but this engine allows retaining the backward compatibility of the configuration generation logic.
          Then this engine can be reused in plugins like Windows Agents Plugin (FKA Windows Slaves Plugin).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java http://jenkins-ci.org/commit/windows-slave-installer-module/89cffceb16b9969bc79c4f7308cab0c19dce7f07 Log: JENKINS-42745 - Windows Agent Installer should generate valid jenkins-slave.xml for old APIs This change is maybe quite over-engineered, but this engine allows retaining the backward compatibility of the configuration generation logic. Then this engine can be reused in plugins like Windows Agents Plugin (FKA Windows Slaves Plugin).

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
          src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java
          http://jenkins-ci.org/commit/windows-slave-installer-module/a3b83c82f27e41f089d2d79b930d2c92e27919f1
          Log:
          Merge pull request #10 from oleg-nenashev/feature/JENKINS-42745

          JENKINS-42745 - Windows Agent Installer should generate valid jenkins-slave.xml for old APIs

          Compare: https://github.com/jenkinsci/windows-slave-installer-module/compare/981a03888c8e...a3b83c82f27e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java http://jenkins-ci.org/commit/windows-slave-installer-module/a3b83c82f27e41f089d2d79b930d2c92e27919f1 Log: Merge pull request #10 from oleg-nenashev/feature/ JENKINS-42745 JENKINS-42745 - Windows Agent Installer should generate valid jenkins-slave.xml for old APIs Compare: https://github.com/jenkinsci/windows-slave-installer-module/compare/981a03888c8e...a3b83c82f27e

          Oleg Nenashev added a comment -

          The fix has been merged towards 2.60.

          Backporting is not required

          Oleg Nenashev added a comment - The fix has been merged towards 2.60. Backporting is not required

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: