Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42967

NUnitPublisher no longer respects failIfNoResults

    XMLWordPrintable

Details

    Description

      Since the implementation of SimpleBuildStep, the boolean returning implementation of "perform" is no longer called, and the void returning version does nothing when NUnitArchiver returns false.

      See https://github.com/jenkinsci/nunit-plugin/blob/master/src/main/java/hudson/plugins/nunit/NUnitPublisher.java, lines 141 and 275.

      Attachments

        Issue Links

          Activity

            Code changed in jenkins
            User: Alex Earl
            Path:
            pom.xml
            src/main/java/hudson/plugins/nunit/NUnitArchiver.java
            src/main/java/hudson/plugins/nunit/NUnitPublisher.java
            src/main/java/hudson/plugins/nunit/NUnitReportTransformer.java
            src/main/resources/hudson/plugins/nunit/NUnitPublisher/config.jelly
            src/main/resources/index.jelly
            src/test/java/hudson/plugins/nunit/NUnitArchiverTest.java
            src/test/java/hudson/plugins/nunit/NUnitIntegrationTest.java
            src/test/java/hudson/plugins/nunit/NUnitPublisherTest.java
            src/test/java/hudson/plugins/nunit/NUnitReportTransformerTest.java
            src/test/java/hudson/plugins/nunit/NUnitToJUnitXslTest.java
            src/test/resources/hudson/plugins/nunit/NUnit-issue34452.xml
            http://jenkins-ci.org/commit/nunit-plugin/5bd699cedeae13475a3321637da3d5c47397b362
            Log:
            Fix JENKINS-27618, JENKINS-27906, JENKINS-34452, JENKINS-42967

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: pom.xml src/main/java/hudson/plugins/nunit/NUnitArchiver.java src/main/java/hudson/plugins/nunit/NUnitPublisher.java src/main/java/hudson/plugins/nunit/NUnitReportTransformer.java src/main/resources/hudson/plugins/nunit/NUnitPublisher/config.jelly src/main/resources/index.jelly src/test/java/hudson/plugins/nunit/NUnitArchiverTest.java src/test/java/hudson/plugins/nunit/NUnitIntegrationTest.java src/test/java/hudson/plugins/nunit/NUnitPublisherTest.java src/test/java/hudson/plugins/nunit/NUnitReportTransformerTest.java src/test/java/hudson/plugins/nunit/NUnitToJUnitXslTest.java src/test/resources/hudson/plugins/nunit/NUnit-issue34452.xml http://jenkins-ci.org/commit/nunit-plugin/5bd699cedeae13475a3321637da3d5c47397b362 Log: Fix JENKINS-27618 , JENKINS-27906 , JENKINS-34452 , JENKINS-42967
            slide_o_mix Alex Earl added a comment -

            Will be fixed in 0.19

            slide_o_mix Alex Earl added a comment - Will be fixed in 0.19

            People

              slide_o_mix Alex Earl
              rgonzalez_virtualware Ruben Gonzalez
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: