Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42969

Computer.addAction will throw UnsupportedOperationException

      The fix of JENKINS-39555 (in 2.30) reverted some of the code introduced in JENKINS-39404, to fix some regressions there. Unfortunately it failed to revert one of the simplifications that was legitimately made in JENKINS-39404 to code originally introduced in JENKINS-18224: so now Computer.addAction is again inherited from Actionable, but will not work since getActions is an immutable list.

      Probably no one noticed this before because no one was trying to call Computer.addAction, but egutierrez noticed that yesterday's security release of ssh-slaves by mc1arke introduced code which does, and which causes a failure in TrustHostKeyActionTest.testSubmitNotAuthorised when run against 2.32.3:

      java.lang.UnsupportedOperationException
      	at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055)
      	at hudson.model.Actionable.addAction(Actionable.java:134)
      	at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70)
      

          [JENKINS-42969] Computer.addAction will throw UnsupportedOperationException

          Daniel Beck added a comment -

          Is there a change in the plugin possible to make this work for current LTS users?

          Daniel Beck added a comment - Is there a change in the plugin possible to make this work for current LTS users?

          Jesse Glick added a comment -

          Yes, see plugin PR.

          Jesse Glick added a comment - Yes, see plugin PR.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/model/labels/LabelAtom.java
          test/src/test/java/hudson/model/ComputerTest.java
          http://jenkins-ci.org/commit/jenkins/838357700d3173380170ecb28f131a554da0af63
          Log:
          [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/labels/LabelAtom.java test/src/test/java/hudson/model/ComputerTest.java http://jenkins-ci.org/commit/jenkins/838357700d3173380170ecb28f131a554da0af63 Log: [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/model/labels/LabelAtom.java
          test/src/test/java/hudson/model/ComputerTest.java
          http://jenkins-ci.org/commit/jenkins/da67b374b0c1fa2875c8dac86acb03907d41ff2a
          Log:
          [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.
          (cherry picked from commit 838357700d3173380170ecb28f131a554da0af63)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/labels/LabelAtom.java test/src/test/java/hudson/model/ComputerTest.java http://jenkins-ci.org/commit/jenkins/da67b374b0c1fa2875c8dac86acb03907d41ff2a Log: [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction. (cherry picked from commit 838357700d3173380170ecb28f131a554da0af63)

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: