Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44589

Missing calls to Jenkins.cleanUp

    XMLWordPrintable

Details

    Description

      Jenkins failed to perform some cleanup tasks, including saving the build queue, if stopped via REST /exit ~ CLI shutdown, or when restarting from Install as Windows Service.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32820 Queue is not persisted on Safe Restart when Jenkins is installed as Windows Service (clean up is not performed)

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 2908

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick added a comment -

            Similar to JENKINS-32820.

            jglick Jesse Glick added a comment - Similar to  JENKINS-32820 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/0ec25081ee5bc6c547632790cd258fa0b6fbcac6
            Log:
            Merge pull request #2908 from jglick/cleanUp

            JENKINS-44589 Adding some missing calls to cleanUp

            Compare: https://github.com/jenkinsci/jenkins/compare/59ae1f69fc6e...0ec25081ee5b

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/0ec25081ee5bc6c547632790cd258fa0b6fbcac6 Log: Merge pull request #2908 from jglick/cleanUp JENKINS-44589 Adding some missing calls to cleanUp Compare: https://github.com/jenkinsci/jenkins/compare/59ae1f69fc6e...0ec25081ee5b
            danielbeck Daniel Beck added a comment -

            Fixed towards 2.64.

            danielbeck Daniel Beck added a comment - Fixed towards 2.64.
            chrismahoneyboprc Chris Mahoney added a comment -

            Is there something special that needs to be done to get this working? I updated to LTS 2.60.2, added a build to the queue, restarted the Windows service... and the queue got cleared. What's the "trick" for making the queue persist?

            chrismahoneyboprc Chris Mahoney added a comment - Is there something special that needs to be done to get this working? I updated to LTS 2.60.2, added a build to the queue, restarted the Windows service... and the queue got cleared. What's the "trick" for making the queue persist?
            jglick Jesse Glick added a comment -

            chrismahoneyboprc probably a shutdown from the Windows service does not shut down Jenkins cleanly. Not sure, not tested. Tracked as JENKINS-30909.

            jglick Jesse Glick added a comment - chrismahoneyboprc probably a shutdown from the Windows service does not shut down Jenkins cleanly. Not sure, not tested. Tracked as  JENKINS-30909 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/92a3e42068c5c54c2861d73d3c2e5fe0c5b64f39
            Log:
            Merge pull request #2908 from jglick/cleanUp

            JENKINS-44589 Adding some missing calls to cleanUp

            (cherry picked from commit 0ec25081ee5bc6c547632790cd258fa0b6fbcac6)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/92a3e42068c5c54c2861d73d3c2e5fe0c5b64f39 Log: Merge pull request #2908 from jglick/cleanUp JENKINS-44589 Adding some missing calls to cleanUp (cherry picked from commit 0ec25081ee5bc6c547632790cd258fa0b6fbcac6)

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: