-
Bug
-
Resolution: Fixed
-
Major
It is a follow-up to https://github.com/jenkinsci/jenkins/pull/2923#discussion_r123202990 . The most of Remoting calls in Jenkins should not be really executed when the channel is shutting down. In our case it was a Launcher for Node (JENKINS-38527)
I expected channel.call() to handle it, but it does not... The only handler is https://github.com/jenkinsci/remoting/blob/a762e0703a04ae41fbd413b2379d57f80fc282b2/src/main/java/hudson/remoting/Channel.java#L604-L605 , which effectively checks for the closed channel after a bunch of operations. IMHO Channel should provide a new API for user-space calls which should not be performed in parallel with close. Making it a default behavior seems to be a breaking change though, needs much testing
- depends on
-
JENKINS-43985 Update Remoting Java requirement to Java 8
-
- Resolved
-
- is related to
-
JENKINS-46067 Pipeline task scheduled on uninitialized node
-
- Open
-
-
JENKINS-45294 Remoting should reject RPCRequests over the closing channel
-
- Resolved
-
-
JENKINS-43038 Intermittent error "Cannot contact node123: java.lang.InterruptedException " in jenkins
-
- Closed
-
- links to
(2 links to)
[JENKINS-45023] Channel#call() should reject requests if the channel is being closed
Link |
New:
This issue depends on |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Assignee | New: Oleg Nenashev [ oleg_nenashev ] |
Epic Link | New: JENKINS-38833 [ 175240 ] |
Issue Type | Original: New Feature [ 2 ] | New: Bug [ 1 ] |
Summary | Original: Channel#call() should be able to reject requests if the channel is being closed | New: Channel#call() should reject requests if the channel is being closed |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
In order to do it properly, we likely need a new default implementation in the VirtualChannel interface. Hence we need to migrate Remoting to Java 8 (
JENKINS-43985).