[JENKINS-45438] HTTP/2 Support

        Code changed in jenkins
        User: Olivier Lamy
        Path:
        pom.xml
        src/main/java/Main.java
        http://jenkins-ci.org/commit/extras-executable-war/70229bb90168a4af3752bb735206ae5934ce48ec
        Log:
        Merge pull request #11 from olamy/feature/http2_connector_missing_service_loader

        JENKINS-45438 - Set context classloader to get ServiceLoader mechanism working

        Compare: https://github.com/jenkinsci/extras-executable-war/compare/dec7ac76428b...70229bb90168

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: pom.xml src/main/java/Main.java http://jenkins-ci.org/commit/extras-executable-war/70229bb90168a4af3752bb735206ae5934ce48ec Log: Merge pull request #11 from olamy/feature/http2_connector_missing_service_loader JENKINS-45438 - Set context classloader to get ServiceLoader mechanism working Compare: https://github.com/jenkinsci/extras-executable-war/compare/dec7ac76428b...70229bb90168

        Code changed in jenkins
        User: Olivier Lamy
        Path:
        README.md
        pom.xml
        src/java/winstone/AbstractSecuredConnectorFactory.java
        src/java/winstone/Http2ConnectorFactory.java
        src/java/winstone/HttpsConnectorFactory.java
        src/java/winstone/Launcher.java
        src/java/winstone/LocalStrings.properties
        src/java/winstone/cmdline/Option.java
        src/test/winstone/HttpsConnectorFactoryTest.java
        http://jenkins-ci.org/commit/winstone/f589eca607cea3fb1cab53574a15beb3eab98b9f
        Log:
        Merge pull request #39 from olamy/feature/http2

        JENKINS-45438 Add HTTP/2 connector

        Compare: https://github.com/jenkinsci/winstone/compare/e995aaf558fd...f589eca607ce

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: README.md pom.xml src/java/winstone/AbstractSecuredConnectorFactory.java src/java/winstone/Http2ConnectorFactory.java src/java/winstone/HttpsConnectorFactory.java src/java/winstone/Launcher.java src/java/winstone/LocalStrings.properties src/java/winstone/cmdline/Option.java src/test/winstone/HttpsConnectorFactoryTest.java http://jenkins-ci.org/commit/winstone/f589eca607cea3fb1cab53574a15beb3eab98b9f Log: Merge pull request #39 from olamy/feature/http2 JENKINS-45438 Add HTTP/2 connector Compare: https://github.com/jenkinsci/winstone/compare/e995aaf558fd...f589eca607ce

        Code changed in jenkins
        User: Olivier Lamy
        Path:
        pom.xml
        war/pom.xml
        http://jenkins-ci.org/commit/jenkins/19f2d66334cbfaa8d501a97c0c2f82474344baca
        Log:
        Merge pull request #2937 from olamy/feature/jetty_http2_connector

        JENKINS-45438 Add Jetty HTTP/2 connector

        Compare: https://github.com/jenkinsci/jenkins/compare/e952bbaff332...19f2d66334cb

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: pom.xml war/pom.xml http://jenkins-ci.org/commit/jenkins/19f2d66334cbfaa8d501a97c0c2f82474344baca Log: Merge pull request #2937 from olamy/feature/jetty_http2_connector JENKINS-45438 Add Jetty HTTP/2 connector Compare: https://github.com/jenkinsci/jenkins/compare/e952bbaff332...19f2d66334cb

        Oleg Nenashev added a comment -

        It has been released in Jenkins 2.71

        Oleg Nenashev added a comment - It has been released in Jenkins 2.71

        This is broken since 2.128 there was an upgrade to winstone and thus jetty to version 9.4.8 but jetty changed the loading to use a service loader mechanism provided by the classpath. Since jenkins default installation is using the -jar command there is no way to pass the Service jar files to the command line of jenkins. -jar command line ignores any other jars provided using -classpath. Additionally these can't be passed using -Xbootclasspath either they throw a ClassNotFoundException for the jetty.ssl classes.

         

        Trying to use conscrypt is also a non starter due to the previous issue. There is a possibility winstone can use the common URLClassLoader for loading the server classes but that is not what is happening. winstone initializes the Common ClassLoader before the listeners but doesn't do anything with it until after the listeners are started.

         

        Samuel Gabriel added a comment - This is broken since 2.128 there was an upgrade to winstone and thus jetty to version 9.4.8 but jetty changed the loading to use a service loader mechanism provided by the classpath. Since jenkins default installation is using the -jar command there is no way to pass the Service jar files to the command line of jenkins. -jar command line ignores any other jars provided using -classpath. Additionally these can't be passed using -Xbootclasspath either they throw a ClassNotFoundException for the jetty.ssl classes.   Trying to use conscrypt is also a non starter due to the previous issue. There is a possibility winstone can use the common URLClassLoader for loading the server classes but that is not what is happening. winstone initializes the Common ClassLoader before the listeners but doesn't do anything with it until after the listeners are started.  

        Samuel Gabriel added a comment - - edited

        This is broken since 2.128 there was an upgrade to winstone and thus jetty to version 9.4.8 but jetty changed the loading to use a service loader mechanism provided by the classpath. Since jenkins default installation is using the -jar command there is no way to pass the Service jar files to the command line of jenkins. -jar command line ignores any other jars provided using -classpath. Additionally these can't be passed using -Xbootclasspath either they throw a ClassNotFoundException for the jetty.ssl classes.

         

        Trying to use conscrypt is also a non starter due to the previous issue. There is a possibility winstone can use the common URLClassLoader for loading the server classes but that is not what is happening. winstone initializes the Common ClassLoader before the listeners but doesn't do anything with it until after the listeners are started.

         

        Please see JENKINS-52358 for more details

         

        Samuel Gabriel added a comment - - edited This is broken since 2.128 there was an upgrade to winstone and thus jetty to version 9.4.8 but jetty changed the loading to use a service loader mechanism provided by the classpath. Since jenkins default installation is using the -jar command there is no way to pass the Service jar files to the command line of jenkins. -jar command line ignores any other jars provided using -classpath. Additionally these can't be passed using -Xbootclasspath either they throw a ClassNotFoundException for the jetty.ssl classes.   Trying to use conscrypt is also a non starter due to the previous issue. There is a possibility winstone can use the common URLClassLoader for loading the server classes but that is not what is happening. winstone initializes the Common ClassLoader before the listeners but doesn't do anything with it until after the listeners are started.   Please see  JENKINS-52358  for more details  

        Olivier Lamy added a comment -

        please do not reopen issue.
        We now have this one JENKINS-52358

        Olivier Lamy added a comment - please do not reopen issue. We now have this one JENKINS-52358

          olamy Olivier Lamy
          olamy Olivier Lamy
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

            Created:
            Updated:
            Resolved: