Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46250

Allow Bitbucket build status text to be overridden

      Currently the text sent to Bitbucket as build status for a commit is hardcoded with messages that could be misleading (such as "This commit has test failures") if the job uses build statuses differently (i.e. UNSTABLE happens to mean something else).  At the very least the text should say "The commit is unstable".

      https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java#L73

       

      if (Result.SUCCESS.equals(result)) {
      status = new BitbucketBuildStatus(hash, "This commit looks good", "SUCCESSFUL", url, key, name);
      } else if (Result.UNSTABLE.equals(result)) {
      status = new BitbucketBuildStatus(hash, "This commit has test failures", "FAILED", url, key, name);
      } else if (Result.FAILURE.equals(result)) {
      status = new BitbucketBuildStatus(hash, "There was a failure building this commit", "FAILED", url, key,
      name);
      } else if (result != null) { // ABORTED etc.
      status = new BitbucketBuildStatus(hash, "Something is wrong with the build of this commit", "FAILED", url,
      key, name);
      } else {
      status = new BitbucketBuildStatus(hash, "The tests have started...", "INPROGRESS", url, key, name);
      }
      

        

          [JENKINS-46250] Allow Bitbucket build status text to be overridden

          pixman20 created issue -
          pixman20 made changes -
          Summary Original: Allow Bitbucket build status text to be overridden New: Allow Bitbucket build status text to be disabled/overridden
          James Dumay made changes -
          Link New: This issue relates to JENKINS-35453 [ JENKINS-35453 ]
          pixman20 made changes -
          Summary Original: Allow Bitbucket build status text to be disabled/overridden New: Allow Bitbucket build status text overridden
          pixman20 made changes -
          Summary Original: Allow Bitbucket build status text overridden New: Allow Bitbucket build status text to be overridden
          pixman20 made changes -
          Description Original: Currently the text sent to Bitbucket as build status for a commit is hardcoded with messages that could be misleading (such as "This commit has test failures") if the job uses build statuses differently (i.e. UNSTABLE happens to mean something else).  At the very least the text should say "The commit is unstable".

          [https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java#L73]

           
          {code:java}
          if (Result.SUCCESS.equals(result)) {
          status = new BitbucketBuildStatus(hash, "This commit looks good", "SUCCESSFUL", url, key, name);
          } else if (Result.UNSTABLE.equals(result)) {
          status = new BitbucketBuildStatus(hash, "This commit has test failures", "FAILED", url, key, name);
          } else if (Result.FAILURE.equals(result)) {
          status = new BitbucketBuildStatus(hash, "There was a failure building this commit", "FAILED", url, key,
          name);
          } else if (result != null) { // ABORTED etc.
          status = new BitbucketBuildStatus(hash, "Something is wrong with the build of this commit", "FAILED", url,
          key, name);
          } else {
          status = new BitbucketBuildStatus(hash, "The tests have started...", "INPROGRESS", url, key, name);
          }
          {code}
           

          Also, the URL display text in Bitbucket should be able to be overridden so that the build number is only the default.  This is especially important when marking the build status of a Pull Request, since it's commit hash might have 2 build status updates: 1 for the corresponding PR build and 1 for the corresponding branch build of the branch being PR'ed. 

          Currently when this happens, there are 2 links on the build status icon, but both are only a number.  The only way to tell which one is the PR build and which one is the branch build is by hovering over the URL to see where it goes.  Being able to override the link's text would help a user to know which link goes where.

          [https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java#L69]

           
          {code:java}
          String name = build.getDisplayName(); // use the build number as the display name of the status
          {code}
           

          Additionally, the notifications should also be able to be disabled.

           
          New: Currently the text sent to Bitbucket as build status for a commit is hardcoded with messages that could be misleading (such as "This commit has test failures") if the job uses build statuses differently (i.e. UNSTABLE happens to mean something else).  At the very least the text should say "The commit is unstable".

          [https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java#L73]

           
          {code:java}
          if (Result.SUCCESS.equals(result)) {
          status = new BitbucketBuildStatus(hash, "This commit looks good", "SUCCESSFUL", url, key, name);
          } else if (Result.UNSTABLE.equals(result)) {
          status = new BitbucketBuildStatus(hash, "This commit has test failures", "FAILED", url, key, name);
          } else if (Result.FAILURE.equals(result)) {
          status = new BitbucketBuildStatus(hash, "There was a failure building this commit", "FAILED", url, key,
          name);
          } else if (result != null) { // ABORTED etc.
          status = new BitbucketBuildStatus(hash, "Something is wrong with the build of this commit", "FAILED", url,
          key, name);
          } else {
          status = new BitbucketBuildStatus(hash, "The tests have started...", "INPROGRESS", url, key, name);
          }
          {code}
            
          Kalle Niemitalo made changes -
          Link New: This issue relates to JENKINS-36755 [ JENKINS-36755 ]
          Dee Kryvenko made changes -
          Link New: This issue is related to JENKINS-65741 [ JENKINS-65741 ]

            Unassigned Unassigned
            pixman20 pixman20
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: