Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47158

Warnings about workflow/*-parallel-synthetic.xml serializing WorkflowRun objects

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean - Candidates

      Description

      I get the following message in the log:

      -JENKINS-45892-: reference to Bitbucket/cvltk/PR-4 #9 being saved from unexpected /var/lib/jenkins/jobs/Bitbucket/jobs/cvltk/branches/PR-4/builds/9/workflow/4-parallel-synthetic.xml

      I'm doing some tricks to build in parallel on multiple different nodes, maybe that is the cause. Condensed example Jenkinsfile:

      platforms = [
  "gcc4.8-linux64": [nodeMatcher: 'linux64', config: "linux-gcc4.8"],
]

@NonCPS
def generateBuilds()
{
  def builds = [:]
  for (p in platforms) {
    def name = p.key
    def platform = p.value
    builds[p.key] = { build(name, platform) }
  }
  return builds
}

def build(name, platform)
{
  node(platform.nodeMatcher) {
    stage("Build ${name}") {
      echo "Hello, World for ${platform.config}!"
    }
  }
}

parallel generateBuilds()

        Attachments

          Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-45892 Forbid nested references to model objects

          • Major - Major loss of function.
          • Resolved
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. JENKINS-47736 JEP-200: Switch Remoting/XStream blacklist to a whitelist

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. INFRA-1431 Out of disk space on root partition on ci.jenkins.io

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          links to

          Web Link PR #1584

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            8 older comments
            Hide
            Permalink
            abayer Andrew Bayer added a comment -

            FYI Michael Neale and James Dumay - this is causing major problems on ci.jenkins.io due to the logspam that gets generated. Don't know if it's causing other problems beyond the logspam, but it's filling the disk every couple days, which is bad, obviously. This needs to get fixed ASAP.

            Show
            abayer Andrew Bayer added a comment - FYI Michael Neale and James Dumay - this is causing major problems on ci.jenkins.io due to the logspam that gets generated. Don't know if it's causing other problems beyond the logspam, but it's filling the disk every couple days, which is bad, obviously. This needs to get fixed ASAP.
            Hide
            Permalink
            abayer Andrew Bayer added a comment -

            Ok, I decided to tackle this - https://github.com/jenkinsci/blueocean-plugin/pull/1584. It's a minimal bandaid - just keeps the synthetic FlowNode created in PipelineNodeGraphVisitor for parallel branches from being saved to disk. It doesn't address the underlying design problem of using a synthetic FlowNode in the first place, but it does get Blue Ocean to stop violating JENKINS-45892. Assuming all the tests pass - I honestly haven't run them all locally and am counting on CI. =)

            Jesse Glick - fyi, I couldn't add you as a reviewer to the PR, since you're not a committer on blueocean-plugin, but I wanted to make sure you take a look at it.

            Show
            abayer Andrew Bayer added a comment - Ok, I decided to tackle this - https://github.com/jenkinsci/blueocean-plugin/pull/1584 . It's a minimal bandaid - just keeps the synthetic FlowNode created in PipelineNodeGraphVisitor for parallel branches from being saved to disk. It doesn't address the underlying design problem of using a synthetic FlowNode in the first place, but it does get Blue Ocean to stop violating JENKINS-45892 . Assuming all the tests pass - I honestly haven't run them all locally and am counting on CI. =) Jesse Glick - fyi, I couldn't add you as a reviewer to the PR, since you're not a committer on blueocean-plugin , but I wanted to make sure you take a look at it.
            Hide
            Permalink
            michaelneale Michael Neale added a comment -

            thanks Andrew Bayer - Vivek Pandey will review shortly, but LGTM. 

             

            Should we put this in the release 1.3 branch and roll one if it is bugging people? 

            Show
            michaelneale Michael Neale added a comment - thanks Andrew Bayer - Vivek Pandey will review shortly, but LGTM.    Should we put this in the release 1.3 branch and roll one if it is bugging people? 
            Hide
            Permalink
            michaelneale Michael Neale added a comment -

            this was rolled in 1.3.5 release too FWIW

            Show
            michaelneale Michael Neale added a comment - this was rolled in 1.3.5 release too FWIW
            Hide
            Permalink
            kshultz Karl Shultz added a comment -

            Testing Notes:
            Andrew provided a test as part of the PR.

            Show
            kshultz Karl Shultz added a comment - Testing Notes: Andrew provided a test as part of the PR.

              People

              Assignee:
              abayer Andrew Bayer
              Reporter:
              estyrke Emil Styrke
              Votes:
              4 Vote for this issue
              Watchers:
              13 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: