Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47324

FilePath API in Jenkins should propagate errors

    XMLWordPrintable

Details

    Description

      Almost all methods in https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/FilePath.java use obsolete pre-Java7 API, which does not propagate errors.

      • The code should be updated to java.nio.Files: https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html
      • Methods should propagate errors via IOExceptions where possible (and log errors to java.util.logging.Logger otherwise)
      • Runtime exceptions from the new API should be caught if the methods throw them (e.g. InvalidPathException)

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34855 AtomicFileWriter isn't Atomic

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-36088 Use NIO rather than JNR whenever possible

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-48227 Use "Files.createTempDirectory" to create temp directory

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-48405 Use NIO in Util.deleteFile for better error messages

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link jenkinsci/jenkins#3864

          Web Link PR-3173 from KrishanBhasin

          Activity

            Ascending order - Click to sort in descending order
            View 15 older comments
            oleg_nenashev Oleg Nenashev added a comment -

            danielbeck IIUC there are still some changes to be done in this ticket

            oleg_nenashev Oleg Nenashev added a comment - danielbeck IIUC there are still some changes to be done in this ticket
            batmat Baptiste Mathus added a comment -

            I feel like the acceptance criteria are slightly unclear, then it makes it hard to be sure this is done or not. I see at least the PR from krishbhasin and dnusbaum in https://github.com/jenkinsci/jenkins/pull/3135.

             oleg_nenashev given you filed this, *when you have time* could you possibly add acceptance criteria so it's easily assessable by anyone if/when this would be done?

            Spassiba!

            batmat Baptiste Mathus added a comment - I feel like the acceptance criteria are slightly unclear, then it makes it hard to be sure this is done or not. I see at least the PR from krishbhasin and dnusbaum  in https://github.com/jenkinsci/jenkins/pull/3135.   oleg_nenashev given you filed this, * when you have time * could you possibly add acceptance criteria so it's easily assessable by anyone if/when this would be done? Spassiba!
            batmat Baptiste Mathus added a comment - - edited

            krishbhasin would you be BTW be available/willing to handle the possible remainder of this task, if any? We're happy to provide any guidance for this. Thanks!

            batmat Baptiste Mathus added a comment - - edited krishbhasin would you be BTW be available/willing to handle the possible remainder of this task, if any? We're happy to provide any guidance for this. Thanks!
            dnusbaum Devin Nusbaum added a comment -

            Krishan submitted https://github.com/jenkinsci/jenkins/pull/3173, https://github.com/jenkinsci/jenkins/pull/3135 from me was more related to JENKINS-36088. There are likely other things that could be addressed, but I think we got most of the lowest-hanging fruit looking at the related issues and glancing quickly through FilePath.java.

            dnusbaum Devin Nusbaum added a comment - Krishan submitted https://github.com/jenkinsci/jenkins/pull/3173 , https://github.com/jenkinsci/jenkins/pull/3135 from me was more related to JENKINS-36088 . There are likely other things that could be addressed, but I think we got most of the lowest-hanging fruit looking at the related issues and glancing quickly through FilePath.java .
            batmat Baptiste Mathus added a comment -

            OK, then let's consider this fixed until proven otherwise. Like I wrote above anyway, it can be reopened anytime once we know about left things to be still fixed. Thanks for the feedback Devin.

            batmat Baptiste Mathus added a comment - OK, then let's consider this fixed until proven otherwise. Like I wrote above anyway, it can be reopened anytime once we know about left things to be still fixed. Thanks for the feedback Devin.

            People

              krishbhasin Krishan Bhasin
              oleg_nenashev Oleg Nenashev
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: