-
Task
-
Resolution: Fixed
-
Major
-
Powered by SuggestiMate
As of Jenkins Security Advisory 2017-10-11 CommandLauncher configuration enforces RUN_SCRIPTS, which is awkward for cases where a lower-privileged user is permitted to configure other aspects of an agent. The launcher should be moved out of core into a plugin that can depend on script-security for a regular approval workflow.
[JENKINS-47393] Split CommandLauncher into a plugin and integrate with script-security
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
src/main/java/org/jvnet/hudson/test/JenkinsRule.java
src/main/java/org/jvnet/hudson/test/SimpleCommandLauncher.java
src/main/resources/org/jvnet/hudson/test/SimpleCommandLauncher/config.jelly
http://jenkins-ci.org/commit/jenkins-test-harness/175e6b4e7d2dcb810fe9e9c127f295229424748f
Log:
Merge pull request #79 from jglick/CommandLauncher-JENKINS-47393
JENKINS-47393 Remove signature and runtime references to CommandLauncher
Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/2d7d6b8a4480...175e6b4e7d2d
Code changed in jenkins
User: Jesse Glick
Path:
command-launcher-plugin/pom.xml
command-launcher-plugin/src/main/java/hudson/slaves/CommandConnector.java
command-launcher-plugin/src/main/java/hudson/slaves/CommandLauncher.java
command-launcher-plugin/src/main/java/org/jenkinsci/plugins/command_launcher/CommandLanguage.java
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config.jelly
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_bg.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_de.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_es.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_ja.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_pt_BR.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_sr.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandConnector/config_zh_TW.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config.jelly
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_bg.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_da.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_de.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_es.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_fr.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_ja.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_pt_BR.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_ru.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_sr.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_sv_SE.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_tr.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/config_zh_TW.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help-command.html
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help-command_bg.html
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help-command_fr.html
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help-command_ja.html
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help-command_ru.html
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help.jelly
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help_bg.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help_de.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help_es.properties
command-launcher-plugin/src/main/resources/hudson/slaves/CommandLauncher/help_sr.properties
command-launcher-plugin/src/main/resources/index.jelly
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_bg.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_da.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_de.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_es.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_fr.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_ja.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_lt.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_pt_BR.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_sr.properties
command-launcher-plugin/src/main/resources/org/jenkinsci/plugins/command_launcher/Messages_zh_TW.properties
command-launcher-plugin/src/test/java/hudson/slaves/CommandConnectorTest.java
command-launcher-plugin/src/test/java/hudson/slaves/CommandLauncher2Test.java
command-launcher-plugin/src/test/java/hudson/slaves/CommandLauncherTest.java
command-launcher-plugin/src/test/resources/hudson/slaves/CommandLauncher2Test/ancientSerialForm/config.xml
core/src/main/java/hudson/ClassicPluginStrategy.java
core/src/main/java/hudson/model/Slave.java
core/src/main/java/hudson/slaves/CommandConnector.java
core/src/main/java/hudson/slaves/CommandLauncher.java
core/src/main/resources/hudson/model/Messages.properties
core/src/main/resources/hudson/model/Messages_bg.properties
core/src/main/resources/hudson/model/Messages_de.properties
core/src/main/resources/hudson/model/Messages_es.properties
core/src/main/resources/hudson/model/Messages_lt.properties
core/src/main/resources/hudson/model/Messages_sr.properties
core/src/main/resources/hudson/slaves/CommandConnector/config.jelly
core/src/main/resources/hudson/slaves/CommandConnector/config_bg.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_de.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_es.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_ja.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_pt_BR.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_sr.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_zh_TW.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config.jelly
core/src/main/resources/hudson/slaves/CommandLauncher/config_bg.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_da.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_de.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_es.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_fr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_ja.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_pt_BR.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_ru.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_sr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_sv_SE.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_tr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_zh_TW.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help-command.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_bg.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_fr.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ja.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ru.html
core/src/main/resources/hudson/slaves/CommandLauncher/help.jelly
core/src/main/resources/hudson/slaves/CommandLauncher/help.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_bg.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_de.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_es.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_sr.properties
core/src/main/resources/hudson/slaves/Messages.properties
core/src/main/resources/hudson/slaves/Messages_bg.properties
core/src/main/resources/hudson/slaves/Messages_da.properties
core/src/main/resources/hudson/slaves/Messages_de.properties
core/src/main/resources/hudson/slaves/Messages_es.properties
core/src/main/resources/hudson/slaves/Messages_fr.properties
core/src/main/resources/hudson/slaves/Messages_ja.properties
core/src/main/resources/hudson/slaves/Messages_pt_BR.properties
core/src/main/resources/hudson/slaves/Messages_sr.properties
core/src/main/resources/hudson/slaves/Messages_zh_TW.properties
pom.xml
test/pom.xml
test/src/test/java/hudson/slaves/CommandLauncher2Test.java
test/src/test/java/hudson/slaves/CommandLauncherTest.java
test/src/test/java/hudson/slaves/ComputerConnectorTest.java
test/src/test/java/jenkins/tasks/SimpleBuildWrapperTest.java
war/pom.xml
http://jenkins-ci.org/commit/jenkins/e376780c649523c32d3acc0140ed47b45aa57464
Log:
JENKINS-47393 Preparation for split of CommandLauncher to a plugin.
Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/hudson/ClassicPluginStrategy.java
core/src/main/java/hudson/model/Slave.java
core/src/main/java/hudson/slaves/CommandConnector.java
core/src/main/java/hudson/slaves/CommandLauncher.java
core/src/main/resources/hudson/model/Messages.properties
core/src/main/resources/hudson/model/Messages_bg.properties
core/src/main/resources/hudson/model/Messages_de.properties
core/src/main/resources/hudson/model/Messages_es.properties
core/src/main/resources/hudson/model/Messages_lt.properties
core/src/main/resources/hudson/model/Messages_sr.properties
core/src/main/resources/hudson/slaves/CommandConnector/config.jelly
core/src/main/resources/hudson/slaves/CommandConnector/config_bg.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_de.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_es.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_ja.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_pt_BR.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_sr.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_zh_TW.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config.jelly
core/src/main/resources/hudson/slaves/CommandLauncher/config_bg.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_da.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_de.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_es.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_fr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_ja.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_pt_BR.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_ru.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_sr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_sv_SE.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_tr.properties
core/src/main/resources/hudson/slaves/CommandLauncher/config_zh_TW.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help-command.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_bg.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_fr.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ja.html
core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ru.html
core/src/main/resources/hudson/slaves/CommandLauncher/help.jelly
core/src/main/resources/hudson/slaves/CommandLauncher/help.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_bg.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_de.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_es.properties
core/src/main/resources/hudson/slaves/CommandLauncher/help_sr.properties
core/src/main/resources/hudson/slaves/Messages.properties
core/src/main/resources/hudson/slaves/Messages_bg.properties
core/src/main/resources/hudson/slaves/Messages_da.properties
core/src/main/resources/hudson/slaves/Messages_de.properties
core/src/main/resources/hudson/slaves/Messages_es.properties
core/src/main/resources/hudson/slaves/Messages_fr.properties
core/src/main/resources/hudson/slaves/Messages_ja.properties
core/src/main/resources/hudson/slaves/Messages_pt_BR.properties
core/src/main/resources/hudson/slaves/Messages_sr.properties
core/src/main/resources/hudson/slaves/Messages_zh_TW.properties
test/pom.xml
test/src/test/java/hudson/slaves/CommandLauncher2Test.java
test/src/test/java/hudson/slaves/CommandLauncherTest.java
test/src/test/java/hudson/slaves/ComputerConnectorTest.java
test/src/test/java/jenkins/tasks/SimpleBuildWrapperTest.java
war/pom.xml
http://jenkins-ci.org/commit/jenkins/d292929502f88c9839c8d7ffaa337586052312df
Log:
Merge pull request #3076 from jglick/CommandLauncher-JENKINS-47393
JENKINS-47393 Split CommandLauncher to a plugin
Compare: https://github.com/jenkinsci/jenkins/compare/8ac33fdecea0...d292929502f8
Code changed in jenkins
User: Jesse Glick
Path:
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
http://jenkins-ci.org/commit/plugin-compat-tester/6161799eb3e73a8901ca43c23843d6206381140c
Log:
JENKINS-47393 PCT against 2.86+ needs to know about command-launcher split.
Code changed in jenkins
User: Andres Rodriguez
Path:
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
http://jenkins-ci.org/commit/plugin-compat-tester/aed1bab19ac477b74a5d9218fb5b724384d01c7c
Log:
Merge pull request #46 from jglick/CommandLauncher-JENKINS-47393
JENKINS-47393 PCT against 2.86+ needs to know about command-launcher split
Compare: https://github.com/jenkinsci/plugin-compat-tester/compare/593fc901ecce...aed1bab19ac4
Code changed in jenkins
User: Andres Rodriguez
Path:
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
http://jenkins-ci.org/commit/plugin-compat-tester/c241be4210da2073b0bb1a9d944f0f3de51e48fd
Log:
Revert "JENKINS-47393 PCT against 2.86+ needs to know about command-launcher split"
Code changed in jenkins
User: Andres Rodriguez
Path:
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
http://jenkins-ci.org/commit/plugin-compat-tester/5bb27a5b79f5ee76ba0bf3d4150af4a13d9d8984
Log:
Merge pull request #47 from jenkinsci/revert-46-CommandLauncher-JENKINS-47393
Revert "JENKINS-47393 PCT against 2.86+ needs to know about command-launcher split"
Compare: https://github.com/jenkinsci/plugin-compat-tester/compare/aed1bab19ac4...5bb27a5b79f5
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
src/main/java/org/jvnet/hudson/test/JenkinsRule.java
src/main/java/org/jvnet/hudson/test/SimpleCommandLauncher.java
src/main/resources/org/jvnet/hudson/test/SimpleCommandLauncher/config.jelly
http://jenkins-ci.org/commit/jenkins-test-harness/913fb842b8edf01d5a556a10194ea2d6a686618e
Log:
JENKINS-47393Remove signature and runtime references to CommandLauncher.