Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47985

EC2 Plugin doesn't store AMITypeData in config.xml

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • ec2-plugin
    • None

      If EC2 instance doesn't expose AMITypeData, we effectively drop the data in the AMITypeData object. For Windows slaves this means that the password is removed and the instance type is defaulted to unix.

       

      Fix is simple - add a getter and a setter and remove transient amiType property in SlaveTemplate class.

      To replicate :

      • Add an EC2 cloud in Global Config
      • Add a new Slave Template
      • Change the type to Windows
      • Enter password in the Windows Admin Password field
      • Click Save
      • Perform "Reload Configuration From Disk"
      • Go back to Global Config
      • The type of the Slave Template is reset to Unix and password is gone

          [JENKINS-47985] EC2 Plugin doesn't store AMITypeData in config.xml

          Aleksandr Panzin added a comment -

          Added fix here: https://github.com/jenkinsci/ec2-plugin/pull/243

           

          Aleksandr Panzin added a comment - Added fix here: https://github.com/jenkinsci/ec2-plugin/pull/243  

          Santiago Mola added a comment -

          Any progress on this? The PR has been reviewed, approved and tested by multiple people.

          Santiago Mola added a comment - Any progress on this? The PR has been reviewed, approved and tested by multiple people.

          Chris Girard added a comment -

          It's going on 2 months since the fix for this major bug was put forth - any chance we'll see that merged soon?  The current latest version of the plugin is not safe for people to upgrade to.

          Chris Girard added a comment - It's going on 2 months since the fix for this major bug was put forth - any chance we'll see that merged soon?  The current latest version of the plugin is not safe for people to upgrade to.

          Chris Girard added a comment -

          Thank you very much for merging the fix into master for this.  Do you have an estimate for when the next official release of the plugin might be?  People upgrading to latest via Jenkins are still susceptible to this bug.

          Chris Girard added a comment - Thank you very much for merging the fix into master for this.  Do you have an estimate for when the next official release of the plugin might be?  People upgrading to latest via Jenkins are still susceptible to this bug.

          Karlis Zigurs added a comment -

          More importantly how long until it could end up in the LTS branch?

          Karlis Zigurs added a comment - More importantly how long until it could end up in the LTS branch?

          Santiago Mola added a comment -

          Marked as fixed, since the PR has been merged and verified by many people already.

          Santiago Mola added a comment - Marked as fixed, since the PR has been merged and verified by many people already.

          Chris Girard added a comment -

          So how do we go about getting a release put out with this fix incorporated?

          Chris Girard added a comment - So how do we go about getting a release put out with this fix incorporated?

          Thai Pham added a comment -

          When will this fix be released?

          Thai Pham added a comment - When will this fix be released?

          Francis Upton added a comment -

          Fix is released now in version 1.39. Sorry for the delay.

          Francis Upton added a comment - Fix is released now in version 1.39. Sorry for the delay.

            francisu Francis Upton
            jalexoid Aleksandr Panzin
            Votes:
            8 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: