Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47985

EC2 Plugin doesn't store AMITypeData in config.xml

    XMLWordPrintable

Details

    Description

      If EC2 instance doesn't expose AMITypeData, we effectively drop the data in the AMITypeData object. For Windows slaves this means that the password is removed and the instance type is defaulted to unix.

       

      Fix is simple - add a getter and a setter and remove transient amiType property in SlaveTemplate class.

      To replicate :

      • Add an EC2 cloud in Global Config
      • Add a new Slave Template
      • Change the type to Windows
      • Enter password in the Windows Admin Password field
      • Click Save
      • Perform "Reload Configuration From Disk"
      • Go back to Global Config
      • The type of the Slave Template is reset to Unix and password is gone

      Attachments

        Issue Links

          Activity

            francisu Francis Upton added a comment -

            Fix is released now in version 1.39. Sorry for the delay.

            francisu Francis Upton added a comment - Fix is released now in version 1.39. Sorry for the delay.
            thaipham Thai Pham added a comment -

            When will this fix be released?

            thaipham Thai Pham added a comment - When will this fix be released?
            girardc79 Chris Girard added a comment -

            So how do we go about getting a release put out with this fix incorporated?

            girardc79 Chris Girard added a comment - So how do we go about getting a release put out with this fix incorporated?
            smola Santiago Mola added a comment -

            Marked as fixed, since the PR has been merged and verified by many people already.

            smola Santiago Mola added a comment - Marked as fixed, since the PR has been merged and verified by many people already.
            homolupus Karlis Zigurs added a comment -

            More importantly how long until it could end up in the LTS branch?

            homolupus Karlis Zigurs added a comment - More importantly how long until it could end up in the LTS branch?

            People

              francisu Francis Upton
              jalexoid Aleksandr Panzin
              Votes:
              8 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: