Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47985

EC2 Plugin doesn't store AMITypeData in config.xml

    XMLWordPrintable

Details

    Description

      If EC2 instance doesn't expose AMITypeData, we effectively drop the data in the AMITypeData object. For Windows slaves this means that the password is removed and the instance type is defaulted to unix.

       

      Fix is simple - add a getter and a setter and remove transient amiType property in SlaveTemplate class.

      To replicate :

      • Add an EC2 cloud in Global Config
      • Add a new Slave Template
      • Change the type to Windows
      • Enter password in the Windows Admin Password field
      • Click Save
      • Perform "Reload Configuration From Disk"
      • Go back to Global Config
      • The type of the Slave Template is reset to Unix and password is gone

      Attachments

        Issue Links

          Activity

            jalexoid Aleksandr Panzin created issue -
            jalexoid Aleksandr Panzin added a comment - Added fix here: https://github.com/jenkinsci/ec2-plugin/pull/243  
            smola Santiago Mola made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR #243 (Web Link)" [ 19305 ]
            smola Santiago Mola added a comment -

            Any progress on this? The PR has been reviewed, approved and tested by multiple people.

            smola Santiago Mola added a comment - Any progress on this? The PR has been reviewed, approved and tested by multiple people.
            oltzu Olli Sivonen made changes -
            Link This issue is duplicated by JENKINS-48468 [ JENKINS-48468 ]
            girardc79 Chris Girard added a comment -

            It's going on 2 months since the fix for this major bug was put forth - any chance we'll see that merged soon?  The current latest version of the plugin is not safe for people to upgrade to.

            girardc79 Chris Girard added a comment - It's going on 2 months since the fix for this major bug was put forth - any chance we'll see that merged soon?  The current latest version of the plugin is not safe for people to upgrade to.
            girardc79 Chris Girard added a comment -

            Thank you very much for merging the fix into master for this.  Do you have an estimate for when the next official release of the plugin might be?  People upgrading to latest via Jenkins are still susceptible to this bug.

            girardc79 Chris Girard added a comment - Thank you very much for merging the fix into master for this.  Do you have an estimate for when the next official release of the plugin might be?  People upgrading to latest via Jenkins are still susceptible to this bug.
            homolupus Karlis Zigurs added a comment -

            More importantly how long until it could end up in the LTS branch?

            homolupus Karlis Zigurs added a comment - More importantly how long until it could end up in the LTS branch?
            smola Santiago Mola added a comment -

            Marked as fixed, since the PR has been merged and verified by many people already.

            smola Santiago Mola added a comment - Marked as fixed, since the PR has been merged and verified by many people already.
            smola Santiago Mola made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            girardc79 Chris Girard made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 20023 ]
            girardc79 Chris Girard added a comment -

            So how do we go about getting a release put out with this fix incorporated?

            girardc79 Chris Girard added a comment - So how do we go about getting a release put out with this fix incorporated?
            thaipham Thai Pham added a comment -

            When will this fix be released?

            thaipham Thai Pham added a comment - When will this fix be released?
            francisu Francis Upton added a comment -

            Fix is released now in version 1.39. Sorry for the delay.

            francisu Francis Upton added a comment - Fix is released now in version 1.39. Sorry for the delay.
            francisu Francis Upton made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            raihaan Raihaan Shouhell made changes -
            Link This issue is blocked by JENKINS-49207 [ JENKINS-49207 ]

            People

              francisu Francis Upton
              jalexoid Aleksandr Panzin
              Votes:
              8 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: