-
Improvement
-
Resolution: Unresolved
-
Major
-
None
See this discussion and this SECURITY-144 exemption for context. SubversionSCM.descriptor() and SubversionWorkspaceSelector.syncWorkspaceFormatFromMaster must not call Jenkins.getInstanceOrNull or similar. Checking JenkinsJVM is the quick way to determine if code is running on the master or an agent, but really this check should not be necessary at all. Rather, all information about master-side configuration should be prepared on the master and included in the master → slave callable's constructor and serializable state (CheckOutTask for example). PerJobCredentialStoreTest.remoteBuild is a key test.
When fixed and released, the callable.conf entry can be deleted.
- relates to
-
JENKINS-34857 FATAL: Jenkins has not been started, or was already shut down
-
- Resolved
-
-
JENKINS-48638 Simplified/clarified Jenkins.getInstance
-
- Resolved
-
- links to
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/scm/SubversionSCM.java
src/main/java/hudson/scm/SubversionWorkspaceSelector.java
http://jenkins-ci.org/commit/subversion-plugin/3ab1af1e6f3e90e31267eaf52342ded6e753da15
Log:
Noting JENKINS-48543.