• Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • core

      JENKINS-34857 tracks an abortive attempt to make Jenkins.getInstance throw IllegalStateException as it is documented to do. While fixes like JENKINS-48543 could make that possible, it is safer and more straightforward to have one nondeprecated method which is @CheckForNull (but rarely used) and one nondeprecated method which is @Nonnull (and recommended for most callers).

          [JENKINS-48638] Simplified/clarified Jenkins.getInstance

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Hudson.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/resources/META-INF/upgrade/Hudson.hint
          core/src/main/resources/META-INF/upgrade/Jenkins.hint
          http://jenkins-ci.org/commit/jenkins/001a33c747feb437a1bf5f0349b6988f517ec9a8
          Log:
          JENKINS-48638 Deprecate Jenkins.getInstance in favor of (usually) get (#3195)

          • Deprecate Jenkins.getInstance in favor of (usually) getActiveInstance.
          • Introduced get() as a concise non-null accessor.
          • May as well suggest rewrites of getActiveInstance too.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Hudson.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/META-INF/upgrade/Hudson.hint core/src/main/resources/META-INF/upgrade/Jenkins.hint http://jenkins-ci.org/commit/jenkins/001a33c747feb437a1bf5f0349b6988f517ec9a8 Log: JENKINS-48638 Deprecate Jenkins.getInstance in favor of (usually) get (#3195) Deprecate Jenkins.getInstance in favor of (usually) getActiveInstance. Introduced get() as a concise non-null accessor. May as well suggest rewrites of getActiveInstance too.

          Jesse Glick added a comment -

          Merged toward 2.98.

          Jesse Glick added a comment - Merged toward 2.98.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: