This issue is archived. You can view it, but you can't modify it. Learn more

ExportXMLWordPrintable

      I was using the "From users with Admin or Write" permission for "Discover pull requests from forks". A random user opened a PR from their fork against our github.com/keybase/kbfs repository, and Jenkins built it. I'd have expected Jenkins not to build it.

      The description:

      Pull requests forks will be treated as trusted if and only if the fork owner has either Admin or Write permissions on the origin repository. Note that this strategy requires theĀ Review a user's permission levelĀ API, as a result on GitHub Enterprise Server versions before 2.12 this is the same as trustingĀ Nobody.

      Ā 

      Our repositories are open source, so we allow anyone to see them. But only a small set of users have Admin or Write permissions. And yet we had a random user create a pull request, and it got built by Jenkins.

      I've now setĀ the fork permission to "Nobody".

            Assignee:
            Unassigned
            Reporter:
            John Zila
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Archived: