[JENKINS-48997] The new submodule pattern matching breaks submodules with spaces in name - Jenkins Jira

XML

Word

Printable

The new submodule pattern matching introduced in 52f681e6153eb088495edd497a82d6dc919dcae3 commit in git-client-plugin 2.7.0 for ~~JENKINS-46054~~ issue breaks submodules with spaces in name.

The previous pattern was this one:

git config -f .gitmodules --get-regexp "^submodule\.(.*)\.url"

But now it's this one:

git config -f .gitmodules --get-regexp "^submodule\.([^ ]+)\.url"

So submodule with space in name are not matched anymore:

submodule.Submodules/Foo iOS Library.url ssh://git@stash.mobile.bar.com:7999/foo/ios-library.git

It would be better to use a pattern like this one:

git config -f .gitmodules --get-regexp '^submodule\.(.+)\.url$'

duplicates

JENKINS-48818 Git plugin no longer updates submodules with spaces in the name

is related to

JENKINS-46054 Unable to pull submodules that contain ".url" in the url

There are no comments yet on this issue.