The new submodule pattern matching breaks submodules with spaces in name

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      The new submodule pattern matching introduced in 52f681e6153eb088495edd497a82d6dc919dcae3 commit in git-client-plugin 2.7.0 for JENKINS-46054 issue breaks submodules with spaces in name.

      The previous pattern was this one:

      git config -f .gitmodules --get-regexp "^submodule\.(.*)\.url"

      But now it's this one: 

      git config -f .gitmodules --get-regexp "^submodule\.([^ ]+)\.url"

      So submodule with space in name are not matched anymore: 

      submodule.Submodules/Foo iOS Library.url ssh://git@stash.mobile.bar.com:7999/foo/ios-library.git 

       It would be better to use a pattern like this one:

      git config -f .gitmodules --get-regexp '^submodule\.(.+)\.url$'

       

       

            Assignee:
            Mark Waite
            Reporter:
            Francis Labrie
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: