-
Task
-
Resolution: Unresolved
-
Minor
See discussion with maintainer. JENKINS-49054 was more or less a hotfix; the deeper patch to our forked copy of XStream remains unmerged; and there may be other things wrong with our use of RobustReflectionConverter and the like which are not yet reported.
- relates to
-
JENKINS-49054 Lack of finally block in TreeUnmarshaller can cause DescribableList to throw ClassCastException or NoSuchMethodException
-
- Resolved
-
-
JENKINS-73687 Make deserialization of Map fields in XML files more robust
-
- Resolved
-
From what I can tell, most unmarshalling in Jenkins goes through one of our custom converters which do ensure that HierarchicalStreamReader.moveUp calls are balanced. Besides patching TreeUnmarshaller in our fork (assuming the maintainer refuses to accept fixes), a few other important classes like ArrayConverter likely need to be patched as well. The concerns about XML parsers being in an undefined state may or may be relevant for Jenkins, which uses XppDriver; possibly need to switch to XppDomDriver.