Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49169

Investigate XStream stack unwinding behavior esp. in TreeUnmarshaller

    XMLWordPrintable

Details

    Description

      See discussion with maintainer. JENKINS-49054 was more or less a hotfix; the deeper patch to our forked copy of XStream remains unmerged; and there may be other things wrong with our use of RobustReflectionConverter and the like which are not yet reported.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-49054 Lack of finally block in TreeUnmarshaller can cause DescribableList to throw ClassCastException or NoSuchMethodException

          • Major - Major loss of function.
          • Resolved

          Activity

            jglick Jesse Glick added a comment -

            From what I can tell, most unmarshalling in Jenkins goes through one of our custom converters which do ensure that HierarchicalStreamReader.moveUp calls are balanced. Besides patching TreeUnmarshaller in our fork (assuming the maintainer refuses to accept fixes), a few other important classes like ArrayConverter likely need to be patched as well. The concerns about XML parsers being in an undefined state may or may be relevant for Jenkins, which uses XppDriver; possibly need to switch to XppDomDriver.

            jglick Jesse Glick added a comment - From what I can tell, most unmarshalling in Jenkins goes through one of our custom converters which do ensure that HierarchicalStreamReader.moveUp calls are balanced. Besides patching TreeUnmarshaller in our fork (assuming the maintainer refuses to accept fixes), a few other important classes like ArrayConverter likely need to be patched as well. The concerns about XML parsers being in an undefined state may or may be relevant for Jenkins, which uses XppDriver ; possibly need to switch to XppDomDriver .

            People

              Unassigned Unassigned
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: