vivek this one looks reasonably serious - perhaps the code needs to be more defensive for null user properties?

Hi kutzi, Looking at the code, line 109:

if (Favorites.isFavorite(author, job)) {

both author and job are always non-null, something in favorites plugin is throwing NPE. Please provide complete stack trace so that we know where to fix this NPE.

Sorry, I don't see that error anymore and the build logs of the builds, where it happened, are already gone.

You can close the issue if you like to and I'll reopen it if I encounter the issue, again.

kutzi No problem. It might have been fixed since reported. Anyways, reopen it if you find it reproducing. Thanks for reporting.

 I just go this same error (rebuilding fixes it):

{noformat}
GitHub has been notified of this commit’s build result

java.lang.NullPointerException
at io.jenkins.blueocean.autofavorite.FavoritingScmListener.onCheckout(FavoritingScmListener.java:109)
at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:127)
at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:85)
at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:75)
at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)
at hudson.security.ACL.impersonate(ACL.java:290)
at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}

This is using 1.2.2 of the Autofavorite for Blue Ocean Plugin.  This is using Jenkins ver. 2.107.2

As I just noted on https://issues.jenkins-ci.org/browse/JENKINS-50715, we just added Blue Ocean for the first time to our production Jenkins system today, and immediately started seeing this very problem on the first build (#1) of any new branch or PR for every multibranch pipeline job. We're running Jenkins 2.164.1 LTS and the latest versions of all plugins, including Autofavorite 1.2.3. Blue Ocean was installed without a restart (as it was new) but I'm awaiting system availability to restart to remove it; having every build #1 fail is untenable.