Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5047

"Restart when no jobs are running" at the top is confusing

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None

    Description

      The warning text about needing to restart and the button should appear at the bottom of the page, and only after all the pending operations are completed either successfully or unsuccessfully.

      I think that's a much better flow for users, although it does mean a bit more work for us to decide when to display it.

      (JENKINS-3146 is the original request that resulted in this button.)

      Attachments

        Activity

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
          core/src/main/resources/hudson/model/UpdateCenter/index.jelly
          http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2
          Log:
          JENKINS-5047 Fixed JavaScript update during Ajax refresh.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly core/src/main/resources/hudson/model/UpdateCenter/index.jelly http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2 Log: JENKINS-5047 Fixed JavaScript update during Ajax refresh.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          core/src/main/java/hudson/model/UpdateCenter.java
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
          core/src/main/resources/hudson/model/UpdateCenter/index.jelly
          core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
          http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
          Log:
          [FIXED JENKINS-5047] Restart button now adds a restart action to the
          queue instead of restarting immediately.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: core/src/main/java/hudson/model/UpdateCenter.java core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties core/src/main/resources/hudson/model/UpdateCenter/index.jelly core/src/main/resources/hudson/model/UpdateCenter/index_de.properties http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43 Log: [FIXED JENKINS-5047] Restart button now adds a restart action to the queue instead of restarting immediately.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
          http://jenkins-ci.org/commit/jenkins/59234f0a6470756ef3becdeff550eacd7ed309ce
          Log:
          JENKINS-5047 Added 'pending' text to action.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties http://jenkins-ci.org/commit/jenkins/59234f0a6470756ef3becdeff550eacd7ed309ce Log: JENKINS-5047 Added 'pending' text to action.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/119aea8612dee35211b54c03f3a0ec2e014c26d3
          Log:
          JENKINS-5047 Changlog update.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: changelog.html http://jenkins-ci.org/commit/jenkins/119aea8612dee35211b54c03f3a0ec2e014c26d3 Log: JENKINS-5047 Changlog update.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
          core/src/main/resources/hudson/model/UpdateCenter/index.jelly
          http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2
          Log:
          JENKINS-5047 Fixed JavaScript update during Ajax refresh.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly core/src/main/resources/hudson/model/UpdateCenter/index.jelly http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2 Log: JENKINS-5047 Fixed JavaScript update during Ajax refresh.

          People

            drulli Ulli Hafner
            kohsuke Kohsuke Kawaguchi
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: