[JENKINS-50539] Determine critical plugins that depend on git-plugin

Type: Task
Resolution: Done
Priority: Minor
Component/s: evergreen
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show
Epic Link:
git-plugin quality audit for essentials
Sprint:
Evergreen - Milestone 1

We need to determine major plugins that depend on the git-plugin plugin so we can later run the PCT for them in a PR basis to make sure changes in the git-plugin is not breaking other plugins in essentials

is blocking

JENKINS-50540 add the runPCT step to the git-plugin on a PR basis

Closed

Raul Arabaolaza added a comment - 2018-04-24 10:28 - edited

The list of ATH tests that use GitPlugin is:

AnalysisCollectorTest
- should_checkout_pipeline_from_git
- should_open_links_in_folder_dashboard_and_nested_views
CheckstylePluginTest
- should_show_warnings_per_user
ExternalWorkspaceManagerPluginTest
GitPluginTest
GitUserContent
JiraPluginTest
JobDSLPluginTest
- should_create_job_with_github_repository
MultipleSCMPluginTest
WorkflowMultibranchTest
WorkflowPluginTest
- hello_world_from_git
- linear_flow
- parallelTests
- sshGitInsideDocker
- testSharedLibraryFromGithub
GitPluginNoDockerTest

Note that related to the git functionality actually tested an overlap between this tests exists, so there is no need to execute all of them to check that git works fine, next comment will include a "proposal list" of tests to run

Raul Arabaolaza added a comment - 2018-04-24 10:28 - edited The list of ATH tests that use GitPlugin is: AnalysisCollectorTest should_checkout_pipeline_from_git should_open_links_in_folder_dashboard_and_nested_views CheckstylePluginTest should_show_warnings_per_user ExternalWorkspaceManagerPluginTest GitPluginTest GitUserContent JiraPluginTest JobDSLPluginTest should_create_job_with_github_repository MultipleSCMPluginTest WorkflowMultibranchTest WorkflowPluginTest hello_world_from_git linear_flow parallelTests sshGitInsideDocker testSharedLibraryFromGithub GitPluginNoDockerTest Note that related to the git functionality actually tested an overlap between this tests exists, so there is no need to execute all of them to check that git works fine, next comment will include a "proposal list" of tests to run

Raul Arabaolaza added a comment - 2018-04-24 10:48 - edited

After analyzing overlaps I propose the following:

GitPluginTest
GitUserContentTest
MultipleSCMPluginTest
WorkflowPluginTest
- hello_world_from_git
- testSharedLibraryFromGithub

Raul Arabaolaza added a comment - 2018-04-24 10:48 - edited After analyzing overlaps I propose the following: GitPluginTest GitUserContentTest MultipleSCMPluginTest WorkflowPluginTest hello_world_from_git testSharedLibraryFromGithub

Raul Arabaolaza added a comment - 2018-04-24 10:54 - edited

WorkflowMultibranchTest is currently being ignored in CI and does not provide extra coverage for git itself so I do not consider it worthy here, all other proposed tests are currently passing fine in CI

Raul Arabaolaza added a comment - 2018-04-24 10:54 - edited WorkflowMultibranchTest is currently being ignored in CI and does not provide extra coverage for git itself so I do not consider it worthy here, all other proposed tests are currently passing fine in CI

Raul Arabaolaza added a comment - 2018-04-24 11:11

This is the raw list of plugins in the current UC that depend on git plugin:

pipeline-github-lib
github-organization-folder
blueocean-git-pipeline
blueocean
blueocean-pipeline-api-impl
blueocean-pipeline-editor
blueocean-github-pipeline
blueocean-events
blueocean-bitbucket-pipeline
github-autostatus
git-prebuildmerge-trait
pretested-integration
gerrit-code-review
github-branch-source
cloudbees-bitbucket-branch-source
bitbucket-scm-trait-commit-skip
bitbucket-scm-filter-jira-validator
aws-codecommit-jobs
gitea
github-pull-request-build
blueocean-autofavorite
github
ghprb
gitbucket
GatekeeperPlugin
codefresh
bitbucket-build-status-notifier
build-requester
pipeline-githubnotify-step
gitflow
deveo
git-validated-merge
publish-to-bitbucket
analysis-core
github-scm-trait-notification-context
updatebot
ibm-continuous-release
git-parameter
helix-teamhub
ignore-committer-strategy
gitlab-oauth
aws-sqs
jx-resources
jx-pipelines
gerrit-trigger
bigpanda-jenkins
codecommit-url-helper
scm-sqs
hp-application-automation-tools-plugin
delivery-pipeline-plugin
bitbucket-approve
stash-pullrequest-builder
openshift-sync
github-oauth
bitbucket-pullrequest-builder
assembla-merge-request-builder
stashNotifier
gitlab-hook
tracking-git
xpdev
scm2job
artifactory
git-tag-message
view-job-filters
mantis
pom2config
whitesource
trac
aws-codecommit-trigger
maven-release-cascade
repository
jira-ext
git-bisect
backlog
tfs
last-changes
google-analytics-usage-reporter
bitbucket
google-git-notes-publisher
debian-package-builder
git-changelog
codebeamer-xunit-importer
codebeamer-result-trend-updater
flaky-test-handler
coding-webhook
gitlab-plugin
gogs-webhook
google-source-plugin
pipeline-dependency-walker
spoonscript
salesforce-migration-assistant-plugin
travis-yml
ikachan
git-chooser-alternative

Raul Arabaolaza added a comment - 2018-04-24 11:11 This is the raw list of plugins in the current UC that depend on git plugin: pipeline-github-lib github-organization-folder blueocean-git-pipeline blueocean blueocean-pipeline-api-impl blueocean-pipeline-editor blueocean-github-pipeline blueocean-events blueocean-bitbucket-pipeline github-autostatus git-prebuildmerge-trait pretested-integration gerrit-code-review github-branch-source cloudbees-bitbucket-branch-source bitbucket-scm-trait-commit-skip bitbucket-scm-filter-jira-validator aws-codecommit-jobs gitea github-pull-request-build blueocean-autofavorite github ghprb gitbucket GatekeeperPlugin codefresh bitbucket-build-status-notifier build-requester pipeline-githubnotify-step gitflow deveo git-validated-merge publish-to-bitbucket analysis-core github-scm-trait-notification-context updatebot ibm-continuous-release git-parameter helix-teamhub ignore-committer-strategy gitlab-oauth aws-sqs jx-resources jx-pipelines gerrit-trigger bigpanda-jenkins codecommit-url-helper scm-sqs hp-application-automation-tools-plugin delivery-pipeline-plugin bitbucket-approve stash-pullrequest-builder openshift-sync github-oauth bitbucket-pullrequest-builder assembla-merge-request-builder stashNotifier gitlab-hook tracking-git xpdev scm2job artifactory git-tag-message view-job-filters mantis pom2config whitesource trac aws-codecommit-trigger maven-release-cascade repository jira-ext git-bisect backlog tfs last-changes google-analytics-usage-reporter bitbucket google-git-notes-publisher debian-package-builder git-changelog codebeamer-xunit-importer codebeamer-result-trend-updater flaky-test-handler coding-webhook gitlab-plugin gogs-webhook google-source-plugin pipeline-dependency-walker spoonscript salesforce-migration-assistant-plugin travis-yml ikachan git-chooser-alternative

Raul Arabaolaza added a comment - 2018-04-24 11:20

Here is a list of the ones I consider important:

github-organization-folder
blueocean-git-pipeline
blueocean-pipeline-api-impl
blueocean-pipeline-editor
blueocean-github-pipeline
blueocean-events
blueocean-bitbucket-pipeline
github-branch-source
cloudbees-bitbucket-branch-source
blueocean-autofavorite
github
jx-resources
jx-pipelines
bitbucket
gitlab-plugin

Note that not check on existing tests or health status has been performed yet

Raul Arabaolaza added a comment - 2018-04-24 11:20 Here is a list of the ones I consider important: github-organization-folder blueocean-git-pipeline blueocean-pipeline-api-impl blueocean-pipeline-editor blueocean-github-pipeline blueocean-events blueocean-bitbucket-pipeline github-branch-source cloudbees-bitbucket-branch-source blueocean-autofavorite github jx-resources jx-pipelines bitbucket gitlab-plugin Note that not check on existing tests or health status has been performed yet

Raul Arabaolaza added a comment - 2018-04-24 14:35

I have discared some plugins that depended transitively on git but were not using any of its API, so the final list is:

blueocean-git-pipeline
blueocean-pipeline-api-impl
blueocean-github-pipeline
blueocean-events
blueocean-bitbucket-pipeline
github-branch-source
cloudbees-bitbucket-branch-source
blueocean-autofavorite
github
bitbucket
gitlab-plugin

Raul Arabaolaza added a comment - 2018-04-24 14:35 I have discared some plugins that depended transitively on git but were not using any of its API, so the final list is: blueocean-git-pipeline blueocean-pipeline-api-impl blueocean-github-pipeline blueocean-events blueocean-bitbucket-pipeline github-branch-source cloudbees-bitbucket-branch-source blueocean-autofavorite github bitbucket gitlab-plugin

Raul Arabaolaza added a comment - 2018-04-24 14:37

So the end result is:

ATH tests:

GitPluginTest
GitUserContentTest
MultipleSCMPluginTest
WorkflowPluginTest
- hello_world_from_git
- testSharedLibraryFromGithub

Plugins to execute the PCT on changes:

blueocean-git-pipeline
blueocean-pipeline-api-impl
blueocean-github-pipeline
blueocean-events
blueocean-bitbucket-pipeline
github-branch-source
cloudbees-bitbucket-branch-source
blueocean-autofavorite
github
bitbucket
gitlab-plugin

Raul Arabaolaza added a comment - 2018-04-24 14:37 So the end result is: ATH tests: GitPluginTest GitUserContentTest MultipleSCMPluginTest WorkflowPluginTest hello_world_from_git testSharedLibraryFromGithub Plugins to execute the PCT on changes: blueocean-git-pipeline blueocean-pipeline-api-impl blueocean-github-pipeline blueocean-events blueocean-bitbucket-pipeline github-branch-source cloudbees-bitbucket-branch-source blueocean-autofavorite github bitbucket gitlab-plugin

Raul Arabaolaza added a comment - 2018-04-25 11:15

CC markwaite To see if he sees any problem

Raul Arabaolaza added a comment - 2018-04-25 11:15 CC markwaite To see if he sees any problem

Mark Waite added a comment - 2018-04-25 14:19

I appreciate the careful reduction of the tests to be run. The list looks good to me.

Mark Waite added a comment - 2018-04-25 14:19 I appreciate the careful reduction of the tests to be run. The list looks good to me.

Assignee:: Raul Arabaolaza

Reporter:: Isa Vilacides

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2018-04-03 09:56

Updated:: 2018-04-25 14:46

Resolved:: 2018-04-25 14:46

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 10:28, Edited by Raul Arabaolaza - 2018-04-24 10:30

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 10:28, Edited by Raul Arabaolaza - 2018-04-24 10:30

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 10:48, Edited by Raul Arabaolaza - 2018-04-24 10:54

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 10:48, Edited by Raul Arabaolaza - 2018-04-24 10:54

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 10:54, Edited by Raul Arabaolaza - 2018-04-24 10:55

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 10:54, Edited by Raul Arabaolaza - 2018-04-24 10:55

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 11:11

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 11:11

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 11:20

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 11:20

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 14:35

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 14:35

Collapse comment: Raul Arabaolaza added a comment - 2018-04-24 14:37

Expand comment: Raul Arabaolaza added a comment - 2018-04-24 14:37

Collapse comment: Raul Arabaolaza added a comment - 2018-04-25 11:15

Expand comment: Raul Arabaolaza added a comment - 2018-04-25 11:15

Collapse comment: Mark Waite added a comment - 2018-04-25 14:19

Expand comment: Mark Waite added a comment - 2018-04-25 14:19

People

Dates