Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50752

ArgumentsAction Can Fail Serialization Of FlowNodes and Build When Given Unserializable input

      Although it shouldn't happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. This can fail the whole persistence of the flow graph, causing loss of data.

      Instead we should intercept and filter out unserializable inputs when the action is created.

          [JENKINS-50752] ArgumentsAction Can Fail Serialization Of FlowNodes and Build When Given Unserializable input

          Sam Van Oort added a comment -

          Similar issue in a related domain

          Sam Van Oort added a comment - Similar issue in a related domain

          Sam Van Oort added a comment -

          Implementation PR

          Sam Van Oort added a comment - Implementation PR

          Sam Van Oort added a comment -

          API addition

          Sam Van Oort added a comment - API addition

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/e9fe93d891cac44d384bd4ade64ea6fc2c4de1f3
          Log:
          Bulletproof against JENKINS-50752 by catching unserializable step arguments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/e9fe93d891cac44d384bd4ade64ea6fc2c4de1f3 Log: Bulletproof against JENKINS-50752 by catching unserializable step arguments

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/19f72df00ef47f76d039fa40ce2535811baee63a
          Log:
          Merge pull request #220 from svanoort/unserializable-args-JENKINS-50752

          Bulletproof against JENKINS-50752 by catching unserializable step arguments

          Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/64187fdcf999...19f72df00ef4

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/19f72df00ef47f76d039fa40ce2535811baee63a Log: Merge pull request #220 from svanoort/unserializable-args- JENKINS-50752 Bulletproof against JENKINS-50752 by catching unserializable step arguments Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/64187fdcf999...19f72df00ef4

          Oleg Nenashev added a comment -

          The fix has been released in Pipeline: CPS 2.48. I will add it to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200

          Oleg Nenashev added a comment - The fix has been released in Pipeline: CPS 2.48. I will add it to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java
          http://jenkins-ci.org/commit/pipeline-utility-steps-plugin/44165d639385cede4367bd4360cbd15339f8542f
          Log:
          JENKINS-50633 - Pick up Pipeline: CPS version with JENKINS-50752

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java http://jenkins-ci.org/commit/pipeline-utility-steps-plugin/44165d639385cede4367bd4360cbd15339f8542f Log: JENKINS-50633 - Pick up Pipeline: CPS version with JENKINS-50752

            svanoort Sam Van Oort
            svanoort Sam Van Oort
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: