-
Improvement
-
Resolution: Fixed
-
Major
-
None
-
Hudson 1.340
Currently Build.RunnerImpl.cleanUp() calls BuildTrigger.execute().. this triggers ALL jobs that have been added as downstream jobs by any DependecyDeclarer (yes, the class name has a typo).. only BuildTrigger itself gets any special handling: triggering only if status threshold is met.. if the downstream connection is made by any other impl, it will trigger the job always, even if this build failed or was aborted! Furthermore, downstream jobs are triggered with just UpstreamCause, with no opportunity for those Declarers to provide any additional Actions (like build parameters).
Need to expand this API so Declarers can control whether a build is triggered and provide Actions to submit with the build.
- is blocking
-
JENKINS-5184 No up/downstream indication when using Parameterized Build Trigger plugin
-
- Resolved
-
-
JENKINS-4069 ivy plugin triggers new downstream builds even if current build failed or aborted
-
- Closed
-
Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/model/Build.java
trunk/hudson/main/core/src/main/java/hudson/model/DependencyGraph.java
trunk/hudson/main/core/src/main/java/hudson/tasks/BuildTrigger.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=25751
Log:
JENKINS-5236Introduce DependencyGraph.Dependency so DependecyDeclarers can controlwhether builds are triggered and provide Actions for the triggered build.
(previously only tasks.BuildTrigger had hardcoded support for logic on whether or
not to trigger.. now it uses this mechanism)