Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52004

Add java.activation module to Java 10 Docker packages

XMLWordPrintable

      Currently we have the module enabled automatically only for Java 11.
      duemir recently reported that it was needed to Run on his instance, so it would worth to add the module to Java 10 packaging as well.

      The following file should be patched: https://github.com/jenkinsci/docker/blob/java10/jenkins.sh

        1. java.xml.bind.desc
          4 kB
          Denys Digtiar

          [JENKINS-52004] Add java.activation module to Java 10 Docker packages

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-40689 [ 177392 ]
          Oleg Nenashev made changes -
          Labels New: java10_hackathon newbie-friendly
          Denys Digtiar made changes -
          Attachment New: java.xml.bind.desc [ 43006 ]

          Denys Digtiar added a comment -

          I ran:

          $JAVA10_HOME/bin/jmod describe $JAVA10_HOME/jmods/java.xml.bind.jmod > java.xml.bind.desc

          And here is what I have got: java.xml.bind.desc

          Specifically of interest is:

          requires java.activation transitive

          Therefore, dependency is explicit and transitive on Java 10 as well. It seems like it might be added automatically by --add-modules java.xml.bind, otherwise, the modular JVM shouldn't start with missing dependency error, as far as I understand.

          Hence, it looks like this task might be a matter of prudence, not a strict requirement.

          Denys Digtiar added a comment - I ran: $JAVA10_HOME/bin/jmod describe $JAVA10_HOME/jmods/java.xml.bind.jmod > java.xml.bind.desc And here is what I have got:  java.xml.bind.desc Specifically of interest is: requires java.activation transitive Therefore, dependency is explicit and transitive on Java 10 as well. It seems like it might be added automatically by --add-modules java.xml.bind , otherwise, the modular JVM shouldn't start with missing dependency error, as far as I understand. Hence, it looks like this task might be a matter of prudence, not a strict requirement.

          Oleg Nenashev added a comment -

          Thanks for the analysis duemir!
          Taking JENKINS-51965 we will likely go forward with bundling the lib and removing need in special flags.
          So I will probably just close this ticket for now

          Oleg Nenashev added a comment - Thanks for the analysis duemir ! Taking JENKINS-51965 we will likely go forward with bundling the lib and removing need in special flags. So I will probably just close this ticket for now
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-51965 [ JENKINS-51965 ]
          Oleg Nenashev made changes -
          Resolution New: Won't Do [ 10001 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Oleg Nenashev made changes -
          Labels Original: java10_hackathon newbie-friendly New: java10_hackathon java11 newbie-friendly

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: