[JENKINS-52007] Plugin POM: Default Animal Sniffer does not work with jdk10

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: plugin-pom
Labels:

Similar Issues:
Powered by SuggestiMate

Show
Epic Link:
Java 11 Phase 4: Deprecate support for Java 8

We need to update Animal Sniffer to a version with ASM6

[ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (check) on project workflow-support: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.: IllegalArgumentException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (check) on project workflow-support: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
	... 20 more
Caused by: java.lang.IllegalArgumentException
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:71)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.processJarFile(ClassFileVisitor.java:153)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.process(ClassFileVisitor.java:105)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.apply(CheckSignatureMojo.java:377)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.buildPackageList(CheckSignatureMojo.java:324)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.execute(CheckSignatureMojo.java:227)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	... 21 more

relates to

JENKINS-52097 Plugin POM should support setting custom Animal Sniffer versions

Resolved

JENKINS-52155 upgrade default animal sniffer plugin to 1.17

Resolved

links to

https://github.com/jenkinsci/workflow-support-plugin/pull/67

https://github.com/mojohaus/animal-sniffer/pull/50

Oleg Nenashev created issue - 2018-06-18 13:01

Oleg Nenashev made changes - 2018-06-18 13:01

Epic Link

New: ~~JENKINS-40689~~ [ 177392 ]

Olivier Lamy added a comment - 2018-06-19 10:59

pr here https://github.com/mojohaus/animal-sniffer/pull/50
just waiting end of ci builds

Olivier Lamy added a comment - 2018-06-19 10:59 pr here https://github.com/mojohaus/animal-sniffer/pull/50 just waiting end of ci builds

Olivier Lamy made changes - 2018-06-19 11:00

Assignee

New: Olivier Lamy [ olamy ]

Oleg Nenashev made changes - 2018-06-19 18:28

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Oleg Nenashev made changes - 2018-06-19 18:28

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Olivier Lamy added a comment - 2018-06-20 08:48

pr merged.
Let me know if all works as expected and I will cut a release.

Olivier Lamy added a comment - 2018-06-20 08:48 pr merged. Let me know if all works as expected and I will cut a release.

Olivier Lamy added a comment - 2018-06-20 23:22

I don't understand the link with "not support multi-release JARs".
The plugin was not supporting jdk10 for sure but not sure about multi release jar.
Do you have any test case or failure stack trace?

Olivier Lamy added a comment - 2018-06-20 23:22 I don't understand the link with "not support multi-release JARs". The plugin was not supporting jdk10 for sure but not sure about multi release jar. Do you have any test case or failure stack trace?

Nicolas De Loof added a comment - 2018-06-21 08:36

olamy AFAICT your fix will still detect java9+ classes within a multi-release jar, typically if I use :
com/foo/Bar.class // plain java 8 implementation
META-INF/versions/9/com/foo/Bar.class // Java9+ implementation relying on new API

animal-sniffer will still complain about use of java 9 APIs in my project, right ?

Nicolas De Loof added a comment - 2018-06-21 08:36 olamy AFAICT your fix will still detect java9+ classes within a multi-release jar, typically if I use : com/foo/Bar.class // plain java 8 implementation META-INF/versions/9/com/foo/Bar.class // Java9+ implementation relying on new API animal-sniffer will still complain about use of java 9 APIs in my project, right ?

Olivier Lamy made changes - 2018-06-21 08:38

Summary

Original: Plugin POM: Default Animal Sniffer Does not support multi-release JARs

New: Plugin POM: Default Animal Sniffer Does not support multi-release JARs neither works with jdk10

Assignee:: Olivier Lamy

Reporter:: Oleg Nenashev

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 2018-06-18 13:01

Updated:: 2018-10-03 21:56

Resolved:: 2018-06-30 20:39

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Olivier Lamy added a comment - 2018-06-19 10:59

Expand comment: Olivier Lamy added a comment - 2018-06-19 10:59

Collapse comment: Olivier Lamy added a comment - 2018-06-20 08:48

Expand comment: Olivier Lamy added a comment - 2018-06-20 08:48

Collapse comment: Olivier Lamy added a comment - 2018-06-20 23:22

Expand comment: Olivier Lamy added a comment - 2018-06-20 23:22

Collapse comment: Nicolas De Loof added a comment - 2018-06-21 08:36

Expand comment: Nicolas De Loof added a comment - 2018-06-21 08:36

People

Dates