Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52007

Plugin POM: Default Animal Sniffer does not work with jdk10

XMLWordPrintable

      We need to update Animal Sniffer to a version with ASM6

      [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (check) on project workflow-support: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.: IllegalArgumentException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (check) on project workflow-support: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed.
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
	... 20 more
Caused by: java.lang.IllegalArgumentException
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:71)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.processJarFile(ClassFileVisitor.java:153)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.process(ClassFileVisitor.java:105)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.apply(CheckSignatureMojo.java:377)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.buildPackageList(CheckSignatureMojo.java:324)
	at org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.execute(CheckSignatureMojo.java:227)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	... 21 more

          [JENKINS-52007] Plugin POM: Default Animal Sniffer does not work with jdk10

          Olivier Lamy added a comment -

          pr here https://github.com/mojohaus/animal-sniffer/pull/50
          just waiting end of ci builds

          Olivier Lamy added a comment - pr here https://github.com/mojohaus/animal-sniffer/pull/50 just waiting end of ci builds

          Olivier Lamy added a comment -

          pr merged.
          Let me know if all works as expected and I will cut a release.

          Olivier Lamy added a comment - pr merged. Let me know if all works as expected and I will cut a release.

          Olivier Lamy added a comment -

          I don't understand the link with "not support multi-release JARs".
          The plugin was not supporting jdk10 for sure but not sure about multi release jar.
          Do you have any test case or failure stack trace?

          Olivier Lamy added a comment - I don't understand the link with "not support multi-release JARs". The plugin was not supporting jdk10 for sure but not sure about multi release jar. Do you have any test case or failure stack trace?

          Nicolas De Loof added a comment -

          olamy AFAICT your fix will still detect java9+ classes within a multi-release jar, typically if I use :
          com/foo/Bar.class // plain java 8 implementation
          META-INF/versions/9/com/foo/Bar.class // Java9+ implementation relying on new API

           

          animal-sniffer will still complain about use of java 9 APIs in my project, right ?

          Nicolas De Loof added a comment - olamy AFAICT your fix will still detect java9+ classes within a multi-release jar, typically if I use : com/foo/Bar.class // plain java 8 implementation META-INF/versions/9/com/foo/Bar.class // Java9+ implementation relying on new API   animal-sniffer will still complain about use of java 9 APIs in my project, right ?

          Oleg Nenashev added a comment -

          ndeloof olamy I would suggest creating a separate issue for that. This one (ASM failure) is fixed

          Oleg Nenashev added a comment - ndeloof olamy I would suggest creating a separate issue for that. This one (ASM failure) is fixed

          Oleg Nenashev added a comment -

          Or we can keep it is a single issue.

          Oleg Nenashev added a comment - Or we can keep it is a single issue.

          Olivier Lamy added a comment -

          ndeloof nope it doesn't this has already been fixed see https://github.com/mojohaus/animal-sniffer/pull/32
          the only issue seems to be able to use animal-sniffer with jdk10

          Olivier Lamy added a comment - ndeloof nope it doesn't this has already been fixed see https://github.com/mojohaus/animal-sniffer/pull/32 the only issue seems to be able to use animal-sniffer with jdk10

          Oleg Nenashev added a comment -

          Fixed by JENKINS-52155

          Oleg Nenashev added a comment - Fixed by JENKINS-52155

            olamy Olivier Lamy
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: