Details
-
Bug
-
Status: Open (View Workflow)
-
Minor
-
Resolution: Unresolved
Description
The ProcessUtils in lib-process-utils allows getting PID from a process using reflection. As part of the general Java 9/10/11 hackathon all setAccessible reflection use was being reviewed.
This issue is to remove the reflection use, and as a nice side effect the code will work on Windows too. However, this requires upgrading to Java 9+, so I don't really expect it to happen anytime soon. For now I wanted to preserve the little bit of work I did.
Attachments
Issue Links
Activity
Jonah Graham
created issue -
Jonah Graham
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
Jonah Graham
made changes -
| Remote Link | This issue links to "https://github.com/jenkinsci/lib-process-utils/pull/2 (Web Link)" [ 20911 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
Jonah Graham
added a comment - It works in Java9+ so far, just gives the standard warning:
WARNING: Illegal reflective access by org.jenkinsci.utils.process.ProcessUtils (file:/scratch/jenkins/git/lib-process-utils/target/classes/) to field java.lang.ProcessImpl.pid
Jonah Graham
added a comment - It works in Java9+ so far, just gives the standard warning:
WARNING: Illegal reflective access by org.jenkinsci.utils.process.ProcessUtils ( file:/scratch/jenkins/git/lib-process-utils/target/classes/ ) to field java.lang.ProcessImpl.pid
| Labels | java10_hackathon |
| Remote Link | This issue links to "convert to multi-release JAR (Web Link)" [ 20924 ] |
Maven Compile r3.8.0 supports Multi-release JARs, so maybe we need another PR
| Labels | java10_hackathon | java10_hackathon java11 |
| Labels | java10_hackathon java11 | java10_hackathon java11 triaged |
As far as I can tell, the process-utils package that is provided by the lib-process-utils GitHub repository is only used in the acceptance test harness and in the docker-fixtures library. Once we've switched to require Java 11, the library can use the Java 11 ProcessHandle class to return the process ID of the current process.
There is no reference to the process-utils package in Jenkins core or in any of the 1500+ plugins that I searched.
| Status | In Review [ 10005 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
Basil Crow
made changes -
| Epic Link |
|
|
Basil Crow
made changes -
| Labels | java10_hackathon java11 triaged | java11 |
Basil Crow
made changes -
| Assignee | Jonah Graham [ jonahgraham ] |
Basil Crow
made changes -
| Component/s | other [ 15490 ] | |
| Component/s | core [ 15593 ] |
Basil Crow
made changes -
| Summary | remove reflection and support Windows in lib-process-utils for getting PID | Illegal reflective access by org.jenkinsci.utils.process.ProcessUtils to field java.lang.ProcessImpl#pid |
Basil Crow
made changes -
| Epic Link |
|
JENKINS-67907 [ 214454 ] |
Basil Crow
made changes -
| Issue Type | Improvement [ 4 ] | Bug [ 1 ] |
It seems the current code is not going to work on Java 9+, right?