Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52704

After update of parent pom, build failure: jenkins/util/SystemProperties must not be used

XMLWordPrintable

      Summary
      blueocean-autofavorite got missed when we updated the parent pom for Blue Ocean. It's still at 2.35, which is causing some PCT failures.

      A simple update causes of pom.xml, as I've done here, causes a failure when trying to mvn clean install. That build failure is:

      [INFO] --- access-modifier-checker:1.15:enforce (default-enforce) @ blueocean-autofavorite ---
[ERROR] io/jenkins/blueocean/autofavorite/FavoritingScmListener:173 jenkins/util/SystemProperties must not be used
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.645 s
[INFO] Finished at: 2018-07-23T10:09:12-04:00
[INFO] Final Memory: 174M/644M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.kohsuke:access-modifier-checker:1.15:enforce (default-enforce) on project blueocean-autofavorite: Access modifier checks failed. See the details above -> [Help 1]

          [JENKINS-52704] After update of parent pom, build failure: jenkins/util/SystemProperties must not be used

          HaiTong Wu added a comment - - edited

          I've got the same problem. 

          In my modification to mesos plugin's code, I also want to get system property like "SystemProperties.getInteger(...)". But when I update the meoso plugin into newest version, it can not build. The message is the same:

          [INFO] — access-modifier-checker:1.15:enforce (default-enforce) @ mesos —
          [ERROR] org/jenkinsci/plugins/mesos/MesosRetentionStrategy:36 jenkins/util/SystemProperties must not be used
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE

          Karl Shultz, have you solved the problem?

          HaiTong Wu added a comment - - edited I've got the same problem.  In my modification to mesos plugin's code, I also want to get system property like "SystemProperties.getInteger(...)". But when I update the meoso plugin into newest version, it can not build. The message is the same: [INFO] — access-modifier-checker:1.15:enforce (default-enforce) @ mesos — [ERROR] org/jenkinsci/plugins/mesos/MesosRetentionStrategy:36 jenkins/util/SystemProperties must not be used [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE Karl Shultz, have you solved the problem?

          Karl Shultz added a comment -

          wuhaitong - I haven't solved the problem, because I haven't been actively working on it. I think this particular plugin needs to go up for adoption, because I suspect jamesdumay has moved on to other things.

          I'd like to make sure I understand you correctly. It sounds like you're trying to do the exact same thing with the mesos plugin - which is, update its parent POM. And doing so causes the plugin to not build anymore. Is that correct?

          This seems like surely it's a problem which has been found, and solved, by someone else. I will ask around.

          Karl Shultz added a comment - wuhaitong - I haven't solved the problem, because I haven't been actively working on it. I think this particular plugin needs to go up for adoption, because I suspect jamesdumay has moved on to other things. I'd like to make sure I understand you correctly. It sounds like you're trying to do the exact same thing with the mesos plugin - which is, update its parent POM. And doing so causes the plugin to not build anymore. Is that correct? This seems like surely it's a problem which has been found, and solved, by someone else. I will ask around.

          HaiTong Wu added a comment -

          Because the velocity of allocation and releasing nodes is too slow, I modify the code of mesos plugin (v0.13.1). It was built OK. Now I want to update mesos plugin version to 0.17, so I merge my modification to source code of v0,17. But it can't be built. I just used the original pom file in mesos plugin source code. Why it built ok in v0.13.2, but no ok in v0.17?

          HaiTong Wu added a comment - Because the velocity of allocation and releasing nodes is too slow, I modify the code of mesos plugin (v0.13.1). It was built OK. Now I want to update mesos plugin version to 0.17, so I merge my modification to source code of v0,17. But it can't be built. I just used the original pom file in mesos plugin source code. Why it built ok in v0.13.2, but no ok in v0.17?

          manus added a comment -

          This can probably be closed, yes?

          manus added a comment - This can probably be closed, yes?

          Liam Newman added a comment -

          This is happening because jenkins/util/SystemProperties was marked as not for external use until very recently.

          https://github.com/jenkinsci/jenkins/commit/0b6e868119a60f6438dd14c419bee818067ff29a

          Liam Newman added a comment - This is happening because jenkins/util/SystemProperties was marked as not for external use until very recently. https://github.com/jenkinsci/jenkins/commit/0b6e868119a60f6438dd14c419bee818067ff29a

            kshultz Karl Shultz
            kshultz Karl Shultz
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: