Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5303

Upgrade Acegi Security to the latest Spring Security release

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • core
    • 2.266

      Please upgrade Acegi Security to the latest Spring Security release. Acegi Security it's old and deprecated.

          [JENKINS-5303] Upgrade Acegi Security to the latest Spring Security release

          Rob Winch added a comment -

          That's quite a bit more APIs that I expected. Given a lot of it is just repackaging.... I'm wondering if we can automate pull requests to Spring Security using https://github.com/Netflix-Skunkworks/rewrite Would this be an option you would consider?

          Rob Winch added a comment - That's quite a bit more APIs that I expected. Given a lot of it is just repackaging.... I'm wondering if we can automate pull requests to Spring Security using https://github.com/Netflix-Skunkworks/rewrite  Would this be an option you would consider?

          Daniel Beck added a comment - - edited

          rwinch

          Given a lot of it is just repackaging

          If it's mostly classes/packages being renamed, could https://github.com/jenkinsci/bytecode-compatibility-transformer/ do the trick then?

          A challenge we have is the long tail of lesser used, not well maintained plugins. If we can make old plugin releases continue to work with new versions of core for relatively low effort, that would be beneficial.

          Especially in a space where failure of the plugin would make login etc. impossible.

          Daniel Beck added a comment - - edited rwinch Given a lot of it is just repackaging If it's mostly classes/packages being renamed, could https://github.com/jenkinsci/bytecode-compatibility-transformer/ do the trick then? A challenge we have is the long tail of lesser used, not well maintained plugins. If we can make old plugin releases continue to work with new versions of core for relatively low effort, that would be beneficial. Especially in a space where failure of the plugin would make login etc. impossible.

          Rob Winch added a comment -

          Thanks for the response and thoughts. It might make sense to use bytecode-compatability-transformer since there are probably plugins that we don't know about. I'm not very familiar with this project. Is it something you would be able to take on?

          Rob Winch added a comment - Thanks for the response and thoughts. It might make sense to use bytecode-compatability-transformer since there are probably plugins that we don't know about. I'm not very familiar with this project. Is it something you would be able to take on?

          runze xia added a comment - http://forum.spring.io/forum/spring-projects/data/ldap/96508-ldap-authentication-intermittent-socket-closed-error

          Wadeck Follonier added a comment - - edited

          Update for 2020 status.
          PR for the usage-in-plugin custom search used: https://github.com/jenkins-infra/usage-in-plugins/pull/15

          Report attached to this ticket: usage-by-api_2020-07-11.html

          Important missing points: the classes used in XxxSecurityRealm.groovy used for building the beans.

          Wadeck Follonier added a comment - - edited Update for 2020 status. PR for the usage-in-plugin custom search used: https://github.com/jenkins-infra/usage-in-plugins/pull/15 Report attached to this ticket: usage-by-api_2020-07-11.html Important missing points: the classes used in XxxSecurityRealm.groovy used for building the beans.

          Jesse Glick added a comment -

          I am investigating whether this effort is feasible.

          Jesse Glick added a comment - I am investigating whether this effort is feasible.

          Rob Winch added a comment -

          Thanks jglick Please let me know if I can be of any assistance.

          Rob Winch added a comment - Thanks jglick Please let me know if I can be of any assistance.

          Jesse Glick added a comment -

          rwinch thanks for the offer! I think I am past the stage where I struggled to find Spring Security 5 equivalents to various Acegi Security idioms that could not be resolved by a simple fix of imports (could not find a clear Rosetta stone except for the 3 → 4 migration). If you can spare any time, by all means skim over the running changes to Jenkins core and comment if you notice any clear abuses of the API. The work going forward will be dealing with compatibility from plugins. There is a draft overview of the effort for background.

          Jesse Glick added a comment - rwinch thanks for the offer! I think I am past the stage where I struggled to find Spring Security 5 equivalents to various Acegi Security idioms that could not be resolved by a simple fix of imports (could not find a clear Rosetta stone except for the 3 → 4 migration ). If you can spare any time, by all means skim over the running changes to Jenkins core and comment if you notice any clear abuses of the API. The work going forward will be dealing with compatibility from plugins. There is a draft overview of the effort for background.

          Jesse Glick added a comment -

          rwinch actually, you could be of assistance if you have any time to spare: I have been struggling in https://github.com/jenkinsci/ldap-plugin/pull/49 to find the Spring Security equivalents of a number of Acegi Security API calls relating to LDAP, not made any easier by the fact that I know little about LDAP itself.

          I have filed a JEP draft for this whole effort.

          Jesse Glick added a comment - rwinch actually, you could be of assistance if you have any time to spare: I have been struggling in https://github.com/jenkinsci/ldap-plugin/pull/49 to find the Spring Security equivalents of a number of Acegi Security API calls relating to LDAP, not made any easier by the fact that I know little about LDAP itself. I have filed a JEP draft for this whole effort.

          jglickcongrats!

          Kanstantsin Shautsou added a comment - jglick congrats!

            jglick Jesse Glick
            nicusorb nicusorb
            Votes:
            22 Vote for this issue
            Watchers:
            21 Start watching this issue

              Created:
              Updated:
              Resolved: