Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53752

Block PRs from forks from untrusted users

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The plugin currently has no way to block untrusted users from making a PR from a fork and having this PR built by Jenkins. The GitHub Pull Request Builder does have this feature which is very useful for open source projects to protect the build system from malicious changes. The documentation on the GitHub Pull Request Builder wiki page says to move from the GHPRB plugin to the GitHub Branch source plugin which causes the user to lose this extremely useful functionality.

        Attachments

          Issue Links

            Activity

            Hide
            brianjmurrell Brian J Murrell added a comment -

            Andrey Babushkin That's not at all how the item description or help text reads.  It very specifically says it will only build a change request / pull request ...

            Show
            brianjmurrell Brian J Murrell added a comment - Andrey Babushkin That's not at all how the item description or help text reads.  It very specifically says it will only build a change request / pull request ...
            Hide
            oxygenxo Andrey Babushkin added a comment -

            I'm sorry Brian J Murrell, It seems I've just screwed the config of my GitHub Organization folder. I've set "Build strategies" like on the picture you've provided and "Trust" to "Nobody". Jenkins creates jobs for PRs opened by untrusted persons, but doesn't run them. That's exactly what I've needed, thank you

            Show
            oxygenxo Andrey Babushkin added a comment - I'm sorry Brian J Murrell , It seems I've just screwed the config of my GitHub Organization folder. I've set "Build strategies" like on the picture you've provided and "Trust" to "Nobody". Jenkins creates jobs for PRs opened by untrusted persons, but doesn't run them . That's exactly what I've needed, thank you
            Hide
            bitwiseman Liam Newman added a comment -

            This is fixed and the feature provided by a plugin

            Show
            bitwiseman Liam Newman added a comment - This is fixed and the feature provided by a plugin
            Hide
            brianjmurrell Brian J Murrell added a comment -

            Liam Newman Could you provide some more details?  Which plugin, at least.

            Show
            brianjmurrell Brian J Murrell added a comment - Liam Newman Could you provide some more details?  Which plugin, at least.
            Hide
            brianjmurrell Brian J Murrell added a comment -

            Liam Newman Perhaps you are referring to [#188| https://github.com/jenkinsci/github-branch-source-plugin/pull/188]. If so I would direct you to the last comment there about JENKINS-58618 and JENKINS-58683, neither of which have even been triaged.

            Show
            brianjmurrell Brian J Murrell added a comment - Liam Newman Perhaps you are referring to [#188| https://github.com/jenkinsci/github-branch-source-plugin/pull/188] . If so I would direct you to the last comment there about JENKINS-58618 and JENKINS-58683 , neither of which have even been triaged.

              People

              Assignee:
              bitwiseman Liam Newman
              Reporter:
              roguishmountain Sam Schwarz
              Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: