Details
-
Type:
Bug
-
Status: Open (View Workflow)
-
Priority:
Major
-
Resolution: Unresolved
-
Component/s: github-branch-source-plugin
-
Labels:
-
Similar Issues:
Description
The plugin has an option to discover PRs from forks and only trust those with admin or write access. The documentation is misleading and makes it sound as thought this will block PRs from untrusted users from being built. Instead this causes the original Jenkinsfile to be used instead of the Jenkinsfile from the fork. Not only is the phrasing of the documentation misleading, it still allows for many vectors of attack such as changing a file that the original Jenkinsfile calls.
Attachments
Issue Links
- relates to
-
JENKINS-53752 Block PRs from forks from untrusted users
-
- Resolved
-
Yeah, "trust" isn't well explained - it means, as you said, that changes to the Jenkinsfile in an untrusted branch will not be used, and the docs do say that, but not clearly enough to establish that it just means that and not that untrusted PRs won't be built at all. I think this and
JENKINS-53752should probably be addressed in tandem.