Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54957

Investigate Impact of java.sql modularization on classic Jenkins modes

    • Jenkinsfile Runner 1.0-beta-6

      I discovered that Jenkinsfile Runner does not work reliably with Java 11 when there is a plugin using "java.sql" internally (JENKINS-54426). It impacts Pipeline Utility Steps (JENKINS-54355), and it will likely also impact Pipeline: Maven Plugin and other plugins: https://github.com/search?p=2&q=org%3Ajenkinsci+%22java.sql%22&type=Code . For JFR the most critical thing is Pipeline plugins, of course.  CC rsandell cleclerc

      We need to investigate whether the failing behavior is also possible on classic Jenkins instances

       

          [JENKINS-54957] Investigate Impact of java.sql modularization on classic Jenkins modes

          Baptiste Mathus added a comment - - edited

          > We need to investigate whether the failing behavior is also possible on classic Jenkins instances

          This has been analyzed by alecharp in JENKINS-54355 and it is not reproducible in a standard environment. Pipeline-utility-steps works perfectly fine on JDK11 without using any additional --add-modules ...,java.sql switch.

          We've seen this issue surface at least in PCT, in JFR, so my current suspicion is that this issue is triggered by a special classloading used there (JTH?).

          Baptiste Mathus added a comment - - edited > We need to investigate whether the failing behavior is also possible on classic Jenkins instances This has been analyzed by alecharp in JENKINS-54355 and it is not reproducible in a standard environment. Pipeline-utility-steps works perfectly fine on JDK11 without using any additional --add-modules ...,java.sql switch. We've seen this issue surface at least in PCT, in JFR, so my current suspicion is that this issue is triggered by a special classloading used there (JTH?).

          Isa Vilacides added a comment -

          Since fcojfernandez removed junit he is the best suited to try to reproduce this issue cause it's likely that it's not happening anymore

          Isa Vilacides added a comment - Since fcojfernandez removed junit he is the best suited to try to reproduce this issue cause it's likely that it's not happening anymore

          Oleg Nenashev added a comment -

          I believe it was fixed by egutierrez in https://github.com/jenkinsci/jenkinsfile-runner/commits/master

           

          If egutierrez and fcojfernandez agree, I propose to close it

          Oleg Nenashev added a comment - I believe it was fixed by egutierrez in https://github.com/jenkinsci/jenkinsfile-runner/commits/master   If egutierrez and fcojfernandez agree, I propose to close it

          Sounds good to me. It should be solved as proved by https://github.com/jenkinsci/jenkinsfile-runner/tree/master/demo/cwp-jdk11

          Evaristo Gutierrez added a comment - Sounds good to me. It should be solved as proved by  https://github.com/jenkinsci/jenkinsfile-runner/tree/master/demo/cwp-jdk11

          Go ahead Oleg! I'm fine with closing it

          Francisco Fernández added a comment - Go ahead Oleg! I'm fine with closing it

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: