Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: branch-api-plugin
-
Labels:None
-
Similar Issues:
Description
When you go to delete a multibranch folder that is using Github as a branch source - you will see a message "delete repository".
This is usually alarming as the access token used often has permissions to actually do this, but this is not the intent.
This is due to the Pronoun for GithubSCMSource being "Repository".
This is then used in https://github.com/jenkinsci/cloudbees-folder-plugin/blob/cloudbees-folder-6.7/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/tasks-new.properties
which ends up with the scary looking:
Attachments
Issue Links
- is caused by
-
JENKINS-38987 SCMHead/SCMSource/SCMNavigator need getPronoun() to assist contextual naming
-
- Closed
-
- links to
Activity
Interesting point:
This is only an issue for the GitHub branch source. No other currently implemented source has this problem.
All others display this way:
This is because no other branch source includes a pronoun, or related implementation changes introduced with JENKINS-38987 - https://github.com/jenkinsci/github-branch-source-plugin/commit/c0557dd3fa8b53e0ff52d315424cebd8fdfd61d9#diff-3f936a67918affedec628eae019f97f3
Also, not this same issue manifests in the GitHub Organization Pipeline:
This looks like we're going to delete an Organization not the GitHub Organization Pipeline.
Merged fix as https://github.com/jenkinsci/branch-api-plugin/pull/150
proposed fix: https://github.com/jenkinsci/github-branch-source-plugin/pull/195 (many other options "delete" is used elsewhere so maybe it isn't a problem, other than in this case). It is deleteing something, just not the repository.