Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54992

Terrifying message makes me think Jenkins will delete my github repo

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • branch-api-plugin
    • None

      When you go to delete a multibranch folder that is using Github as a branch source - you will see a message "delete repository". 

      This is usually alarming as the access token used often has permissions to actually do this, but this is not the intent. 

       

      This is due to the Pronoun for GithubSCMSource being "Repository". 

      see https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L544

      and the wording: https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties#L40

       

      This is then used in https://github.com/jenkinsci/cloudbees-folder-plugin/blob/cloudbees-folder-6.7/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/tasks-new.properties

       

      which ends up with the scary looking: 

       

            fcojfernandez Francisco Fernández
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: