Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55239

FilesystemSCM is not annotated properly in JFR

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • jenkinsfile-runner
    • None

      https://github.com/jenkinsci/jenkinsfile-runner/blob/master/payload/src/main/java/io/jenkins/jenkinsfile/runner/FileSystemSCM.java 

       

      org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class java.lang.String

          [JENKINS-55239] FilesystemSCM is not annotated properly in JFR

          Jesse Glick added a comment -

          Given

          org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class io.jenkins.jenkinsfile.runner.FileSystemSCM
	at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:265)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.<init>(DescribableModel.java:144)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.of(DescribableModel.java:114)
	at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.sanitizeObjectAndRecordMutation(ArgumentsActionImpl.java:294)
	at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.sanitizeMapAndRecordMutation(ArgumentsActionImpl.java:386)
	at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.<init>(ArgumentsActionImpl.java:74)

          I think this could also be treated as a request to turn down the logging in workflow-cps. In particular ArgumentsActionImpl.sanitizeObjectAndRecordMutation should probably be catching NoStaplerConstructorException and recording this as NotStoredReason.UNSERIALIZABLE.

          Jesse Glick added a comment - Given org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class io.jenkins.jenkinsfile.runner.FileSystemSCM at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:265) at org.jenkinsci.plugins.structs.describable.DescribableModel.<init>(DescribableModel.java:144) at org.jenkinsci.plugins.structs.describable.DescribableModel.of(DescribableModel.java:114) at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.sanitizeObjectAndRecordMutation(ArgumentsActionImpl.java:294) at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.sanitizeMapAndRecordMutation(ArgumentsActionImpl.java:386) at org.jenkinsci.plugins.workflow.cps.actions.ArgumentsActionImpl.<init>(ArgumentsActionImpl.java:74) I think this could also be treated as a request to turn down the logging in workflow-cps . In particular ArgumentsActionImpl.sanitizeObjectAndRecordMutation should probably be catching NoStaplerConstructorException and recording this as NotStoredReason.UNSERIALIZABLE .

          Jesse Glick added a comment -

          Filed JENKINS-55372 for the more general issue.

          Jesse Glick added a comment - Filed JENKINS-55372 for the more general issue.

            egutierrez Evaristo Gutierrez
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: