Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55453

Github PR creating job but not building

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • github-branch-source-plugin
    • None

      Since late November 2018 we've consistently had PRs not being built, the job to build them gets created but the build doesn't actually get triggered. There doesn't appear to be anything relevant in the logs that indicate a problem. We were seeing JENKINS-54186 but recent plugin updates seem to have eliminated it but the problem persists.

       

      Things we've tried to address this:

      • Update plugins and core
      • reregister all GitHub webhooks

          [JENKINS-55453] Github PR creating job but not building

          Tyler Pickett added a comment -

          Some additional info on this, we noticed some warnings in the administrative UI and inspected some additional logs and we're getting the following for several of our repos:

          Jan 09, 2019 3:15:26 PM WARNING org.jenkinsci.plugins.github.webhook.WebhookManager$2 applyNullSafeFailed to add GitHub webhook for GitHubRepositoryName[host=github.com,username=Instructure,repository=<repo-name>]
java.io.FileNotFoundException: https://api.github.com/repos/instructure/<repo-name>/hooks/<hook-id>
	at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243)
	at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
	at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25)

          After seeing that I looked at what what GitHub thought those hook-id values should be and they don't match what is in the logs. I wonder if that's the root of our problem. Which config files have that data, I'd like to try to make them match what GitHub has in their UI.

          Tyler Pickett added a comment - Some additional info on this, we noticed some warnings in the administrative UI and inspected some additional logs and we're getting the following for several of our repos: Jan 09, 2019 3:15:26 PM WARNING org.jenkinsci.plugins.github.webhook.WebhookManager$2 applyNullSafeFailed to add GitHub webhook for GitHubRepositoryName[host=github.com,username=Instructure,repository=<repo-name>] java.io.FileNotFoundException: https: //api.github.com/repos/instructure/<repo-name>/hooks/<hook-id> at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243) at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210) at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25) After seeing that I looked at what what GitHub thought those hook-id values should be and they don't match what is in the logs. I wonder if that's the root of our problem. Which config files have that data, I'd like to try to make them match what GitHub has in their UI.

          Tyler Pickett added a comment -

          After looking at this again I'm seeing matching IDs, I could have sworn they didn't match before though. I'll keep trying to gather more info.

          Tyler Pickett added a comment - After looking at this again I'm seeing matching IDs, I could have sworn they didn't match before though. I'll keep trying to gather more info.

          Tyler Pickett added a comment -

          Looking into this some more I'm finding that the IDs keep changing on both ends like they're getting recreated constantly but out of sync.

          Tyler Pickett added a comment - Looking into this some more I'm finding that the IDs keep changing on both ends like they're getting recreated constantly but out of sync.

          Stephen Schmidt added a comment -

          We're also experiencing this issue - lanwen anything immediate come to mind that we might be able to do in order to mitigate the issue?

          Stephen Schmidt added a comment - We're also experiencing this issue - lanwen anything immediate come to mind that we might be able to do in order to mitigate the issue?

          Kirill Merkushev added a comment -

          github plugin itself does nothing with PR webhooks, so it can be something wrong with other plugins. In case you use pipeline - thats full responsibility of Github Branch Source plugin

          Kirill Merkushev added a comment - github plugin itself does nothing with PR webhooks, so it can be something wrong with other plugins. In case you use pipeline - thats full responsibility of Github Branch Source plugin

          Tyler Pickett added a comment - - edited

          Thanks, I realized that after digging in a bit further and didn't come back to update this. Sorry for the trouble.

           

          Leaving this for posterity: After reading through the code it looks like the problem may actually be in the {{github-branch-source }}plugin I'll retag this to that plugin and work on adding some logging around where that trigger is happening to get better insight into what's going on.

          Tyler Pickett added a comment - - edited Thanks, I realized that after digging in a bit further and didn't come back to update this. Sorry for the trouble.   Leaving this for posterity: After reading through the code it looks like the problem may actually be in the {{github-branch-source }}plugin I'll retag this to that plugin and work on adding some logging around where that trigger is happening to get better insight into what's going on.

          Stephen Schmidt added a comment - - edited

          This might be related to https://github.com/jenkinsci/github-branch-source-plugin/pull/183 and the fact that the change was not applied to the GitHubPullRequestFilter class.

          edit: adding this here for posterity as well - https://issues.jenkins-ci.org/browse/JENKINS-46202

          Stephen Schmidt added a comment - - edited This might be related to https://github.com/jenkinsci/github-branch-source-plugin/pull/183  and the fact that the change was not applied to the GitHubPullRequestFilter class. edit: adding this here for posterity as well -  https://issues.jenkins-ci.org/browse/JENKINS-46202

          Stephen Schmidt added a comment - - edited

          jglick or rsandell - Could either of you weigh in on this please? Perhaps related to: https://issues.jenkins-ci.org/browse/JENKINS-54864?

          Stephen Schmidt added a comment - - edited jglick or rsandell - Could either of you weigh in on this please? Perhaps related to:  https://issues.jenkins-ci.org/browse/JENKINS-54864?

          Stephen Schmidt added a comment - - edited

          For posterity - https://issues.jenkins-ci.org/browse/JENKINS-54864?focusedCommentId=355479&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-355479 did resolve the problem.

          cc lanwen do you want to resolve and link to that ticket?

          Stephen Schmidt added a comment - - edited For posterity - https://issues.jenkins-ci.org/browse/JENKINS-54864?focusedCommentId=355479&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-355479  did resolve the problem. cc lanwen do you want to resolve and link to that ticket?

          Liam Newman added a comment -

          https://issues.jenkins-ci.org/browse/JENKINS-54864?focusedCommentId=355479&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-355479

          Liam Newman added a comment - https://issues.jenkins-ci.org/browse/JENKINS-54864?focusedCommentId=355479&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-355479

            lanwen Kirill Merkushev
            tpickett Tyler Pickett
            Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: