Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55738

NodeMonitor out of disk space message is wrong for master

    • Jenkins 2.164

      When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.

      The message has a blank where the node name should be:

      Putting back online as there is enough disk space again

      I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

      Acceptance criteria

      • This should show master instead of a space as the node name, i.e.

      Putting back master online as there is enough disk space

        1. Capture5 - Copy.JPG
          Capture5 - Copy.JPG
          159 kB
        2. image-2019-02-09-00-30-55-101.png
          image-2019-02-09-00-30-55-101.png
          193 kB
        3. Capture2 - Copy.JPG
          Capture2 - Copy.JPG
          193 kB
        4. Capture4 - Copy.JPG
          Capture4 - Copy.JPG
          127 kB
        5. Capture3 - Copy.JPG
          Capture3 - Copy.JPG
          181 kB
        6. Capture3.JPG
          Capture3.JPG
          121 kB
        7. Capture1.JPG
          Capture1.JPG
          59 kB
        8. Capture2.JPG
          Capture2.JPG
          125 kB
        9. Capture1.JPG
          Capture1.JPG
          59 kB

          [JENKINS-55738] NodeMonitor out of disk space message is wrong for master

          Baptiste Mathus created issue -
          Baptiste Mathus made changes -
          Description Original: When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          New: When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          Baptiste Mathus made changes -
          Description Original: When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          New: When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          Nisarg Shah made changes -
          Assignee New: Nisarg Shah [ nisarg14 ]
          Nisarg Shah made changes -
          Comment [ Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? ]
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Nisarg Shah made changes -
          Attachment New: Capture1.JPG [ 45958 ]
          Nisarg Shah made changes -
          Comment [ I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG! ]
          Nisarg Shah made changes -
          Comment [ [~batmat]

          I have tested the fix and I am attaching the screenshot of the result obtained.

          !Capture1.JPG|thumbnail! ]
          Nisarg Shah made changes -
          Attachment New: Capture2.JPG [ 45959 ]
          Nisarg Shah made changes -
          Attachment New: Capture1.JPG [ 45960 ]

            nisarg14 Nisarg Shah
            batmat Baptiste Mathus
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: