-
Bug
-
Resolution: Fixed
-
Trivial
-
-
Jenkins 2.164
When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.
The message has a blank where the node name should be:
Putting back online as there is enough disk space again
I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.
Acceptance criteria
- This should show master instead of a space as the node name, i.e.
Putting back master online as there is enough disk space
[JENKINS-55738] NodeMonitor out of disk space message is wrong for master
Description |
Original:
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
New:
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
Description |
Original:
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
New:
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
Assignee | New: Nisarg Shah [ nisarg14 ] |
Comment | [ Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Attachment | New: Capture1.JPG [ 45958 ] |
Comment | [ I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG! ] |
Comment |
[ [~batmat] I have tested the fix and I am attaching the screenshot of the result obtained. !Capture1.JPG|thumbnail! ] |
Attachment | New: Capture2.JPG [ 45959 ] |
Attachment | New: Capture1.JPG [ 45960 ] |