Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55738

NodeMonitor out of disk space message is wrong for master


    • Jenkins 2.164

      When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.

      The message has a blank where the node name should be:

      Putting back online as there is enough disk space again

      I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

      Acceptance criteria

      • This should show master instead of a space as the node name, i.e.

      Putting back master online as there is enough disk space

        1. Capture1.JPG
          59 kB
          Nisarg Shah
        2. Capture1.JPG
          59 kB
          Nisarg Shah
        3. Capture2.JPG
          125 kB
          Nisarg Shah
        4. Capture2 - Copy.JPG
          193 kB
          Nisarg Shah
        5. Capture3.JPG
          121 kB
          Nisarg Shah
        6. Capture3 - Copy.JPG
          181 kB
          Nisarg Shah
        7. Capture4 - Copy.JPG
          127 kB
          Nisarg Shah
        8. Capture5 - Copy.JPG
          159 kB
          Nisarg Shah
        9. image-2019-02-09-00-30-55-101.png
          193 kB
          Nisarg Shah

            nisarg14 Nisarg Shah
            batmat Baptiste Mathus
            0 Vote for this issue
            4 Start watching this issue