• Jenkins 2.179

      This is the preferred style:


      As opposed to:


      or

       

      –

      I'm going to point to this issue for a bunch of plugins.

       

      Note: my initial efforts relied on using optionalBlock instead of entry + checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving label's from the entry to the checkbox. The rendering won't generally change from the examples above.

       

      Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.

          [JENKINS-55787] Switch labels from entry to checkbox

          Thank you jsoref! I'm speaking about mailer-plugin, as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.

          Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.

          Adrien Lecharpentier added a comment - Thank you jsoref ! I'm speaking about mailer-plugin , as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff. Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table  (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.

          Josh Soref added a comment -

          alecharp: once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

          Josh Soref added a comment - alecharp : once this change is mostly done,  JENKINS-56109  /  jenkinsci/jenkins#3895  will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

          Fritz Elfert added a comment - - edited

          Why is the state of this ticked resolved(fixed) ?
          IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!

          Fritz Elfert added a comment - - edited Why is the state of this ticked resolved(fixed) ? IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!

          Fritz Elfert added a comment -

          Fritz Elfert added a comment - https://github.com/jenkinsci/jclouds-plugin/pull/132 has been merged.

          Igor Rondarev added a comment - - edited

          Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

          Igor Rondarev added a comment - - edited Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report ( JENKINS-59388 ) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

          Igor Rondarev added a comment -

          I've also read JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

          Igor Rondarev added a comment - I've also read  JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

          Gregory Zussa added a comment - Regarding the Datadog Plugin, we should be good with our latest release 1.0.0. Let us know if this is not the case. -  https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration/config.jelly#L77-L81 -  https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogJobProperty/config.jelly#L19

          Basil Crow added a comment -

          FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11.

          Basil Crow added a comment - FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11 .

          Mark Waite added a comment -

          Changes to the git plugin have been released as Git plugin 4.3.0 - June 19, 2020

          Mark Waite added a comment - Changes to the git plugin have been released as Git plugin 4.3.0 - June 19, 2020

          Fritz Elfert added a comment -

          5 years later. Can this be closed now?

          Fritz Elfert added a comment - 5 years later. Can this be closed now?

            jsoref Josh Soref
            jsoref Josh Soref
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: