Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55787

Switch labels from entry to checkbox

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.179

      Description

      This is the preferred style:


      As opposed to:


      or

       

      I'm going to point to this issue for a bunch of plugins.

       

      Note: my initial efforts relied on using optionalBlock instead of entry + checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving label's from the entry to the checkbox. The rendering won't generally change from the examples above.

       

      Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.

        Attachments

          Issue Links

            Activity

            Hide
            d_garry Igor Rondarev added a comment - - edited

            Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

            Show
            d_garry Igor Rondarev added a comment - - edited Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report ( JENKINS-59388 ) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.
            Hide
            d_garry Igor Rondarev added a comment -

            I've also read JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

            Show
            d_garry Igor Rondarev added a comment - I've also read  JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.
            Show
            gzussa Gregory Zussa added a comment - Regarding the Datadog Plugin, we should be good with our latest release 1.0.0. Let us know if this is not the case. -  https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration/config.jelly#L77-L81 -  https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogJobProperty/config.jelly#L19
            Hide
            basil Basil Crow added a comment -

            FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11.

            Show
            basil Basil Crow added a comment - FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11 .
            Hide
            markewaite Mark Waite added a comment -

            Changes to the git plugin have been released as Git plugin 4.3.0 - June 19, 2020

            Show
            markewaite Mark Waite added a comment - Changes to the git plugin have been released as Git plugin 4.3.0 - June 19, 2020

              People

              Assignee:
              jsoref Josh Soref
              Reporter:
              jsoref Josh Soref
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated: