Details
-
Epic
-
Status: In Progress (View Workflow)
-
Minor
-
Resolution: Unresolved
-
-
Jenkins 2.179
Description
This is the preferred style:
As opposed to:
or
–
I'm going to point to this issue for a bunch of plugins.
Note: my initial efforts relied on using optionalBlock instead of entry + checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving label's from the entry to the checkbox. The rendering won't generally change from the examples above.
Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.
Attachments
Issue Links
- is related to
-
JENKINS-61870 Git plugin UI transition for shallow clone needs more changes
-
- Closed
-
- relates to
-
JENKINS-62437
Change Jenkins configuration UI from tables to divs
-
- In Progress
-
-
JENKINS-56109 Jenkins Core: Change Jenkins configuration UI from tables to divs
-
- Closed
-
- links to
Activity
Josh Soref
created issue -
Josh Soref
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Component/s | github-plugin [ 15896 ] | |
| Component/s | workflow-cps-global-lib-plugin [ 21714 ] |
Josh Soref
made changes -
| Component/s | git-plugin [ 15543 ] |
Josh Soref
made changes -
| Component/s | mercurial-plugin [ 15502 ] |
Josh Soref
made changes -
| Component/s | mailer-plugin [ 17522 ] |
Josh Soref
made changes -
| Component/s | bitbucket-branch-source-plugin [ 21428 ] |
Josh Soref
made changes -
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
Josh Soref
made changes -
| Component/s | ssh-slaves-plugin [ 15578 ] |
Josh Soref
made changes -
| Component/s | wix-plugin [ 17462 ] |
Josh Soref
made changes -
| Component/s | tap-plugin [ 15874 ] |
Josh Soref
made changes -
| Summary | Switch from entry to optional block | Switch labels from entry to checkbox |
Josh Soref
made changes -
Josh Soref
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Olivier Lamy
made changes -
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
Olivier Lamy
made changes -
| Labels | jira-plugin-3.0.6 |
Josh Soref
made changes -
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Status | Reopened [ 4 ] | Open [ 1 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Fixed but Unreleased [ 10203 ] |
| Status | Fixed but Unreleased [ 10203 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | In Review [ 10005 ] |
Josh Soref
made changes -
| Component/s | datadog-plugin [ 20826 ] |
Josh Soref
added a comment - I'm not used to using this JIRA either.
Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.
Josh Soref
added a comment - I'm not used to using this JIRA either.
Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature. Josh Soref
made changes -
| Component/s | qc-plugin [ 15759 ] |
Josh Soref
made changes -
| Component/s | hubot-steps-plugin [ 21960 ] |
Josh Soref
made changes -
| Labels | jira-plugin-3.0.6 | jira-plugin-3.0.6 pipeline-model-definition-plugin |
Josh Soref
made changes -
| Labels | jira-plugin-3.0.6 pipeline-model-definition-plugin | jira-plugin-3.0.6 pipeline-model-definition-plugin xunit |
| Component/s | hubot-steps-plugin [ 21960 ] |
Adrien Lecharpentier
added a comment - Thank you jsoref! I'm speaking about mailer-plugin, as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.
Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.
Adrien Lecharpentier
added a comment - Thank you jsoref ! I'm speaking about mailer-plugin , as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.
Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension. Josh Soref
added a comment - alecharp: once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.
Josh Soref
added a comment - alecharp : once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins. | Labels | jira-plugin-3.0.6 pipeline-model-definition-plugin xunit | pipeline-model-definition-plugin xunit |
| Released As | Jenkins 2.179 | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
Josh Soref
made changes -
| Component/s | analysis-core-plugin [ 15709 ] |
Josh Soref
made changes -
| Component/s | timestamper-plugin [ 15749 ] |
Josh Soref
made changes -
| Remote Link | This issue links to "timestamper-plugin#32 (Web Link)" [ 23522 ] |
Josh Soref
made changes -
| Component/s | jobconfighistory-plugin [ 15683 ] |
Josh Soref
made changes -
| Remote Link | This issue links to "jobConfigHistory-plugin#105 (Web Link)" [ 23523 ] |
Josh Soref
made changes -
| Link |
This issue relates to |
Josh Soref
made changes -
| Remote Link | This issue links to "mailer-plugin#52 (Web Link)" [ 23524 ] |
Josh Soref
made changes -
| Component/s | jclouds-plugin [ 16529 ] |
Josh Soref
made changes -
| Remote Link | This issue links to "jclouds-plugin#132 (Web Link)" [ 23525 ] |
Why is the state of this ticked resolved(fixed) ?
IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
Josh Soref
made changes -
| Issue Type | Improvement [ 4 ] | Epic [ 10001 ] |
Josh Soref
made changes -
| Description |
This is the preferred style: !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png! As opposed to: !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png! or !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png! – I'm going to point to this issue for a bunch of plugins. Note: my initial efforts relied on using optionalBlock instead of entry+checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields from the entry to the checkbox. The rendering won't generally change from the examples above. |
This is the preferred style: !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png! As opposed to: !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png! or !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png! – I'm going to point to this issue for a bunch of plugins. Note: my initial efforts relied on using {{optionalBlock}} instead of {{entry}} + {{checkbox}}. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving {{label}}'s from the {{entry}} to the {{checkbox}}. The rendering won't generally change from the examples above. Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins. |
https://github.com/jenkinsci/jclouds-plugin/pull/132 has been merged.
Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.
I've also read JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.
| Status | Reopened [ 4 ] | Open [ 1 ] |
Gregory Zussa
added a comment - Regarding the Datadog Plugin, we should be good with our latest release 1.0.0. Let us know if this is not the case.
Gregory Zussa
added a comment - Regarding the Datadog Plugin, we should be good with our latest release 1.0.0. Let us know if this is not the case.
- https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration/config.jelly#L77-L81
- https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/resources/org/datadog/jenkins/plugins/datadog/DatadogJobProperty/config.jelly#L19 
Basil Crow
added a comment - FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11.
Basil Crow
added a comment - FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11 . Basil Crow
made changes -
| Component/s | timestamper-plugin [ 15749 ] |
| Link |
This issue is related to |
| Link | This issue relates to JENKINS-62437 [ JENKINS-62437 ] |
Changes to the git plugin have been released as Git plugin 4.3.0 - June 19, 2020
| Component/s | git-plugin [ 15543 ] |
Josh Soref
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Component/s | analysis-core-plugin [ 15709 ] |
| Comment | [ Changes to the git plugin have been released. All git plugins are now enabled by default. The default values of some settings have changed and may need to be adjusted. [Ezhazva Matrimony|https://www.bismatrimony.com/matrimony/ezhava-matrimony] ] |
Sorry jsoref! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me.
I apologize. Re-opened.