Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55816

Publish over FTP fails on multi-module project when modules skipped

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have a multi-module project that is built with Jenkins/Maven. When doing a release build, in the cleanup phase, only the top module results in SUCCESS, while the other modules get a SKIPPED, simply because there is nothing to do for them. This looks like this, for example:

      [INFO] Reactor Summary:
      [INFO] 
      [INFO] Main Module #1 .................................... SUCCESS [6:40.776s]
      [INFO] Module #2 ......................................... SKIPPED
      [INFO] Module #3 ......................................... SKIPPED
      [INFO] Module #4 ......................................... SKIPPED
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD SUCCESS
      

       

      It's actually not a problem. The overall result is SUCCESS. However, the Publish Over FTP plugin does not seem to look at the overall result, but seems to see only that some steps did have resulted in something different from SUCCESS, so erroneously assumes a build problem and does not upload the artifacts:

      FTP: Current build result is [NOT_BUILT], not going to run.
      [M2Release] assigning keep build to current build.
      channel stopped
      Finished: SUCCESS.

      There doesn't seem to be a way to work around this, so I hope for a fix in the Publish Over FTP plugin.

       

       

        Attachments

          Issue Links

            Activity

            Hide
            mesa Metin Savignano added a comment -

            You've linked to the Jenkins plugin, so I assumed that this was a Jenkins functionality. In the context of Jenkins, I think it would make sense not to determine the build success within the plugin, but instead let Jenkins take care of that.

            However, maybe it's an idea to create a new option (tickbox) to let the user decide whether the plugin should check the build result or not?

            Show
            mesa Metin Savignano added a comment - You've linked to the Jenkins plugin, so I assumed that this was a Jenkins functionality. In the context of Jenkins, I think it would make sense not to determine the build success within the plugin, but instead let Jenkins take care of that. However, maybe it's an idea to create a new option (tickbox) to let the user decide whether the plugin should check the build result or not?
            Hide
            slide_o_mix Alex Earl added a comment -

            Again, the option to only do things on success, etc is specific to Maven builds. The plugin MUST look at the build status for other builds types. I will look into different options.

            Show
            slide_o_mix Alex Earl added a comment - Again, the option to only do things on success, etc is specific to Maven builds. The plugin MUST look at the build status for other builds types. I will look into different options.
            Hide
            mesa Metin Savignano added a comment -

            I see what you mean.  

            Just FYI, I've found another variation of this problem here. It looks like the getResult() method returns only the result of the last module/component?

            Show
            mesa Metin Savignano added a comment - I see what you mean.   Just FYI, I've found another variation of this problem here . It looks like the getResult() method returns only the result of the last module/component?
            Hide
            mesa Metin Savignano added a comment -

            FYI, I've created a local patch, commenting out the check for build success. Doing so, I've noticed that it's also required to remove the build status update (last few lines in perform method), because it used the wrong NOT_BUILT status it had determined from the previous step to update the status of the whole build to NOT_BUILT, causing the build to be considered failed.

            Show
            mesa Metin Savignano added a comment - FYI, I've created a local patch, commenting out the check for build success. Doing so, I've noticed that it's also required to remove the build status update (last few lines in perform method), because it used the wrong NOT_BUILT status it had determined from the previous step to update the status of the whole build to NOT_BUILT, causing the build to be considered failed.
            Hide
            slide_o_mix Alex Earl added a comment -

            The logic for this is in the parent "publish-over" plugin, so the same issue is affecting both SSH and FTP (also CIFS would be affected as well).

            Show
            slide_o_mix Alex Earl added a comment - The logic for this is in the parent "publish-over" plugin, so the same issue is affecting both SSH and FTP (also CIFS would be affected as well).

              People

              Assignee:
              slide_o_mix Alex Earl
              Reporter:
              mesa Metin Savignano
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: