Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
Centos 5.4
-
-
Jenkins 2.230
Description
If the tree you are archiving contains an internal symlink, the target files will be archived twice. This can lead to a very large increase in the size of the archived data and consequently, the time it takes to archive it.
Example:
/archive-root
/big-directory
/symlink -> big-directory
Then every file in big directory will be archived twice.
A fix would be for Hudson to detect internal symlinks and copy them rather than dereference them.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
Activity
Markus Winter
added a comment - opened a pull request https://github.com/jenkinsci/jenkins/pull/3947 that make follow symlinks configurable
Markus Winter
added a comment - opened a pull request https://github.com/jenkinsci/jenkins/pull/3947 that make follow symlinks configurable 
Aakash Sudhanwa
added a comment - Will this address a similar issue with stash/unstash as well ?
We are using git to checkout sources - which have symbolic links. Then when the sources are stashed and unstashed the symbolic links are lost. They appear as separate directories. This is leading up to a series of issues including bloating up of the sanbox size.
Aakash Sudhanwa
added a comment - Will this address a similar issue with stash/unstash as well ?
We are using git to checkout sources - which have symbolic links. Then when the sources are stashed and unstashed the symbolic links are lost. They appear as separate directories. This is leading up to a series of issues including bloating up of the sanbox size. 
Abhishek Sharma
added a comment - Hi,
Can someone please merge the changes to mains. We're very badly hurt by this issue, and currently building Jenkins manually for this change.
There is a pending merge request https://github.com/jenkinsci/jenkins/pull/3947 that makes follow symlinks configurable.
Thanks,
Abhishek
Abhishek Sharma
added a comment - Hi,
Can someone please merge the changes to mains. We're very badly hurt by this issue, and currently building Jenkins manually for this change.
There is a pending merge request https://github.com/jenkinsci/jenkins/pull/3947 that makes follow symlinks configurable.
Thanks,
Abhishek The change was released in Jenkins 2.230. Thanks to danielbeck wfollonier jthompson for reviews!
Ran into an issue where a build made out of 1000 directory entries over 11 million for the ant DirectoryScanner because of symlinks to directories that again contains symlinks in a subfolder despite having an exclude pattern on the problematic folders.
archive pattern: gen/**/*log
exclude pattern: gen/out/modules/*/
The symlinks were all below gen/out/modules but DirectoryScanner still tried to read everything in before applying the exclude.
Agent process was started with -Xmx8g and ran oom.