Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57122

ToolDescriptor#getDefaultProperties should be marked as Restricted No External Use

XMLWordPrintable

    • Configuration As Code 1.22

      JCasC will attempt to export defaultProperties, and if users than tries to roundtrip the configuration, it will say no attribute is available for defaultProperties which has no setter.
      The method is for form binding, so best to mark this as restricted.
      Signaling to JCasC export it should not be exported, and no one should override it.

          [JENKINS-57122] ToolDescriptor#getDefaultProperties should be marked as Restricted No External Use

          Oleg Nenashev added a comment -

          https://github.com/jenkinsci/jenkins/pull/3992

           

          Oleg Nenashev added a comment - https://github.com/jenkinsci/jenkins/pull/3992  

          Oleg Nenashev added a comment -

          My suggestion is that we actually implement it as a blacklist on the JCasC side.

           

          Oleg Nenashev added a comment - My suggestion is that we actually implement it as a blacklist on the JCasC side.  

          Oleg Nenashev added a comment -

          Custom blacklist was added as a workaround in https://github.com/jenkinsci/configuration-as-code-plugin/pull/925 .See https://github.com/jenkinsci/configuration-as-code-plugin/releases/tag/configuration-as-code-1.22 

          Oleg Nenashev added a comment - Custom blacklist was added as a workaround in  https://github.com/jenkinsci/configuration-as-code-plugin/pull/925  .See  https://github.com/jenkinsci/configuration-as-code-plugin/releases/tag/configuration-as-code-1.22  

            jetersen Joseph Petersen
            casz Joseph Petersen (old)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: