Hi froque,

I'm using the Standard PowerShell arguments, like -ErrorAction and -Verbose in my scripts that are set up before the call from Jenkins (as constants or as Jenkins Job parameter).

For exemple, the -ErrorAction is sometimes "Stop" or "SilentlyContinue", depending of a given need.

And a script might be called outside Jenkins.

Param ( 
 [string]$workspace = $ENV:WORKSPACE,
 [string]$buildMode = $ENV:BUILD_MODE
)
$script = Join-Path $workspace "AthicAuthentication.$buildMode.ps1"
$code = 0
if (Test-Path -Path $script -ErrorAction SilentlyContinue) {
 $code = Invoke-Expression "$script" -ErrorAction Stop
}
exit $code

What changed between 1.3 and 1.4 version that causes this issues ?

Hi froque,

We use these parameters as default values as these scripts are included in some of our build repositories and having commonly used defaults is a nice convenience for end users so they don't have to know every value but can override if they choose to without modifying the script itself.

Does that answer the question?

froque this plugin does not appear to have a default assignee in Jira. I assigned this to you because a CloudBees customer was impacted by this issue, and after I figured out the cause I saw that you did most of the recent work on it. If you will be maintaining the plugin going forward, let me know and I can make you the default assignee for new Jira issues so you will see them.

owenmehegan I became a maintainer for this plugin a couple of months ago. yes, please make me the default assignee. If you could, please make me the default assignee for the plugin-usage-plugin as well, as I also became a maintainer for that plugin, last week.

As for the issue, It is my understanding, that people are reusing existing scripts and pasting directly to the powershell plugin. A will take a look at it.

froque OK, I have made you the default assignee for those two plugins. 

Hello! Just wanted to fan the embers here a bit.

There's a very valid use case for including a param() block in a Powershell script in Jenkins which is broken by this force-setting of ErrorActionPreference. We can set our parameters by tying them to environment variables (which are set as part of parameterized builds) but still retain the ability to run the script with parameters outside of Jenkins without having to maintain a separate script.

One example of how we typically do this on my end:

param ( 
  [string]$foo = if ($ENV:foo) {$ENV:foo} else {'default'},
  [string]$bar= if ($ENV:bar) {$ENV:bar} else {'default'}
)

By forcing the ErrorActionPreference with no option to disable that, the param block no longer works because the param block needs to be the first thing defined in a Powershell script.

Submitted a PR to correct this issue. First time doing a PR for a real repo, so apologies if I've done anything incorrectly, but https://github.com/jenkinsci/powershell-plugin/pull/18

froque mind taking a look when you get a chance? 

sup3rmark_ That code excerpt does not work for me

$ cat test.ps1
param (
  [string]$foo = if ($ENV:foo) {$ENV:foo} else {'default'},
  [string]$bar= if ($ENV:bar) {$ENV:bar} else {'default'}
)
$ pwsh -File test.ps1 
ParserError: (...)/test.ps1:2
Line |
   2 |    [string]$foo = if ($ENV:foo) {$ENV:foo} else {'default'},
     |                  ~
     | Missing expression after '='.

froque sorry, you're right. should be:

param (
  [string]$foo = $(if ($ENV:foo) {$ENV:foo} else {'default'}),
  [string]$bar = $(if ($ENV:bar) {$ENV:bar} else {'default'})
)

Another contributor has gotten around to what I haven't had a chance to do, and submitted a more better change than mine. I've closed my PR in favor of his: https://github.com/jenkinsci/powershell-plugin/pull/21

froque would you please take a look when you have a chance?