Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60821

Check and update any Jetty code with custom threadpool

    • Jenkins 2.218

      As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

      Jesse Glick ​verified the fix in cloudbees-workflow-template-plugin#9 commit 0c4eb98d

      We need to

      • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔
      • make sure other uses of Jetty in Jenkins are safe
      • winstone ✔
      • maven-hpi-plugin (run mojoe etc) ✔

          [JENKINS-60821] Check and update any Jetty code with custom threadpool

          James Nord created issue -
          James Nord made changes -
          Link New: This issue is caused by JENKINS-60694 [ JENKINS-60694 ]
          James Nord made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          James Nord made changes -
          Description Original: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [ https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96]6 [(https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe)]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

           * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.



          slack: [https://cloudbees.slack.com/archives/CBXU9VCGL/p1579285074024500?thread_ts=1579193579.070300&cid=CBXU9VCGL]
          New: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

           * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
          James Nord made changes -
          Description Original: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

           * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
          New: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

           * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
          James Nord made changes -
          Description Original: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

           * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
          New: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

           * make sure other uses of Jetty in Jenkins
               * winstone
               * maven-hpi-plugin (run mojoe etc) ✔
          James Nord made changes -
          Description Original: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

           * make sure other uses of Jetty in Jenkins
               * winstone
               * maven-hpi-plugin (run mojoe etc) ✔
          New: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

           * make sure other uses of Jetty in Jenkins are safe
               * winstone ✔
               * maven-hpi-plugin (run mojoe etc) ✔
          James Nord made changes -
          Description Original: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

           * make sure other uses of Jetty in Jenkins are safe
               * winstone ✔
               * maven-hpi-plugin (run mojoe etc) ✔
          New: As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

          Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

          We need to
           * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

           * make sure other uses of Jetty in Jenkins are safe
               * winstone ✔
               * maven-hpi-plugin (run mojoe etc) ✔
          James Nord made changes -
          Remote Link New: This issue links to "winstone PR#90 (Web Link)" [ 24313 ]
          James Nord made changes -
          Remote Link New: This issue links to "jenkins-test-harness PR#197 (Web Link)" [ 24314 ]
          James Nord made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Fixed but Unreleased [ 10203 ]

            Unassigned Unassigned
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: