Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60821

Check and update any Jetty code with custom threadpool

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.218

      Description

      As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

      Jesse Glick ​verified the fix in cloudbees-workflow-template-plugin#9 commit 0c4eb98d

      We need to

      • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔
      • make sure other uses of Jetty in Jenkins are safe
      • winstone ✔
      • maven-hpi-plugin (run mojoe etc) ✔

        Attachments

          Issue Links

            Activity

            teilo James Nord created issue -
            teilo James Nord made changes -
            Field Original Value New Value
            Link This issue is caused by JENKINS-60694 [ JENKINS-60694 ]
            teilo James Nord made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            teilo James Nord made changes -
            Description As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [ https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96]6 [(https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe)]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

             * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.



            slack: [https://cloudbees.slack.com/archives/CBXU9VCGL/p1579285074024500?thread_ts=1579193579.070300&cid=CBXU9VCGL]
            As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

             * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
            Hide
            teilo James Nord added a comment -

            removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

            Show
            teilo James Nord added a comment - removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"
            teilo James Nord made changes -
            Description As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

             * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
            As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

             * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
            teilo James Nord made changes -
            Description As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

             * make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.
            As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

             * make sure other uses of Jetty in Jenkins
                 * winstone
                 * maven-hpi-plugin (run mojoe etc) ✔
            Hide
            teilo James Nord added a comment -

            maven-hpi-plugin seems unaffected

            winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults)

            Show
            teilo James Nord added a comment - maven-hpi-plugin seems unaffected winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults )
            teilo James Nord made changes -
            Description As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

             * make sure other uses of Jetty in Jenkins
                 * winstone
                 * maven-hpi-plugin (run mojoe etc) ✔
            As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

             * make sure other uses of Jetty in Jenkins are safe
                 * winstone ✔
                 * maven-hpi-plugin (run mojoe etc) ✔
            teilo James Nord made changes -
            Description As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

             * make sure other uses of Jetty in Jenkins are safe
                 * winstone ✔
                 * maven-hpi-plugin (run mojoe etc) ✔
            As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

            Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96] [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

            We need to
             * see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

             * make sure other uses of Jetty in Jenkins are safe
                 * winstone ✔
                 * maven-hpi-plugin (run mojoe etc) ✔
            teilo James Nord made changes -
            Remote Link This issue links to "winstone PR#90 (Web Link)" [ 24313 ]
            teilo James Nord made changes -
            Remote Link This issue links to "jenkins-test-harness PR#197 (Web Link)" [ 24314 ]
            teilo James Nord made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Fixed but Unreleased [ 10203 ]
            teilo James Nord made changes -
            Assignee James Nord [ teilo ]
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            James Nord Winstone fix was shipped in 2.218. Do we need to keep this issue open?

            Show
            oleg_nenashev Oleg Nenashev added a comment - James Nord Winstone fix was shipped in 2.218. Do we need to keep this issue open?
            oleg_nenashev Oleg Nenashev made changes -
            Released As Jenkins 2.218
            Hide
            teilo James Nord added a comment -

            Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

            Show
            teilo James Nord added a comment - Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I will cut the Jetty release

            Show
            oleg_nenashev Oleg Nenashev added a comment - I will cut the Jetty release
            jglick Jesse Glick made changes -
            Link This issue causes JENKINS-60857 [ JENKINS-60857 ]
            Hide
            recena Manuel Recena Soto added a comment -

            The links provided in the issue description are broken. I assume they are private links.

            According to the CHANGELOG, we are able to update the status of this issue. It is already released.

            Show
            recena Manuel Recena Soto added a comment - The links provided in the issue description are broken. I assume they are private links. According to the CHANGELOG , we are able to update the status of this issue. It is already released.
            teilo James Nord made changes -
            Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
            Hide
            teilo James Nord added a comment -

            the link to jetty issue is public. the verification was a private repo

            Show
            teilo James Nord added a comment - the link to jetty issue is public. the verification was a private repo

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              teilo James Nord
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: